Non-zero exit on failure in compile

nebhale · nebhale · commit e0daa2cdca0d · 2013-05-10T09:44:57.000-07:00
Previously, if a failure occurred in compile, the exit code was
undefined. To meet the buildpack contract, a non-zero exit code is now
returned in the case of a failure in the compile script.

[#49421485]
diff --git a/spec/bin/compile_spec.rb b/spec/bin/compile_spec.rb
@@ -0,0 +1,28 @@
+# Cloud Foundry Java Buildpack
+# Copyright (c) 2013 the original author or authors.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#      http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+require 'spec_helper'
+require 'open3'
+
+describe 'compile script' do
+
+  it 'should return non-zero if failure' do
+    Open3.popen3("bin/compile spec/fixtures/invalid_vendor") do |stdin, stdout, stderr, wait_thr|
+      expect(wait_thr.value).to_not be_success
+      expect(stderr.read).to eq("'sun' is not a valid Java runtime vendor\n")
+    end
+  end
+
+end
