Issue #13461: Fix a crash in the TextIOWrapper.tell method and in the "replace"

serhiy-storchaka · serhiy-storchaka · commit fc6a1bcb5e70 · 2013-08-20T20:08:53.000+03:00
error handler on 64-bit platforms.  Patch by Yogesh Chaudhari.
diff --git a/Misc/ACKS b/Misc/ACKS
@@ -170,6 +170,7 @@ Jeffrey Chang
 Mitch Chapman
 Greg Chapman
 Brad Chapman
+Yogesh Chaudhari
 David Chaum
 Nicolas Chauvat
 Michael Chermside
diff --git a/Misc/NEWS b/Misc/NEWS
@@ -9,6 +9,9 @@ What's New in Python 2.7.6?
 Core and Builtins
 -----------------
 
+- Issue #13461: Fix a crash in the "replace" error handler on 64-bit platforms.
+  Patch by Yogesh Chaudhari.
+
 - Issue #15866: The xmlcharrefreplace error handler no more produces two XML
   entities for a non-BMP character on narrow build.
 
@@ -29,6 +32,9 @@ Core and Builtins
 Library
 -------
 
+- Issue #13461: Fix a crash in the TextIOWrapper.tell method on 64-bit
+  platforms.  Patch by Yogesh Chaudhari.
+
 - Issue #18777: The ssl module now uses the new CRYPTO_THREADID API of
   OpenSSL 1.0.0+ instead of the deprecated CRYPTO id callback function.
 
diff --git a/Modules/_io/textio.c b/Modules/_io/textio.c
@@ -2271,7 +2271,7 @@ textiowrapper_tell(textio *self, PyObject *args)
         int dec_flags;
 
         PyObject *decoded = PyObject_CallMethod(
-            self->decoder, "decode", "s#", input, 1);
+            self->decoder, "decode", "s#", input, (Py_ssize_t)1);
         if (check_decoded(decoded) < 0)
             goto fail;
         chars_decoded += PyUnicode_GET_SIZE(decoded);
diff --git a/Python/codecs.c b/Python/codecs.c
@@ -521,7 +521,7 @@ PyObject *PyCodec_ReplaceErrors(PyObject *exc)
         Py_UNICODE res = Py_UNICODE_REPLACEMENT_CHARACTER;
         if (PyUnicodeDecodeError_GetEnd(exc, &end))
             return NULL;
-        return Py_BuildValue("(u#n)", &res, 1, end);
+        return Py_BuildValue("(u#n)", &res, (Py_ssize_t)1, end);
     }
     else if (PyObject_IsInstance(exc, PyExc_UnicodeTranslateError)) {
         PyObject *res;

Original file line number	Diff line number	Diff line change
`@@ -521,7 +521,7 @@ PyObject PyCodec_ReplaceErrors(PyObject exc)`
`521`	`521`	`Py_UNICODE res = Py_UNICODE_REPLACEMENT_CHARACTER;`
`522`	`522`	`if (PyUnicodeDecodeError_GetEnd(exc, &end))`
`523`	`523`	`return NULL;`
`524`		`- return Py_BuildValue("(u#n)", &res, 1, end);`
	`524`	`+ return Py_BuildValue("(u#n)", &res, (Py_ssize_t)1, end);`
`525`	`525`	`}`
`526`	`526`	`else if (PyObject_IsInstance(exc, PyExc_UnicodeTranslateError)) {`
`527`	`527`	`PyObject *res;`