Closed reference leak of variable 'k' in function ste_new which wasn't decrefed in error cases

tiran · tiran · commit f3c965a0c19d · 2012-09-10T03:08:46.000+02:00
diff --git a/Python/symtable.c b/Python/symtable.c
@@ -22,7 +22,7 @@ ste_new(struct symtable *st, identifier name, _Py_block_ty block,
               void *key, int lineno)
 {
     PySTEntryObject *ste = NULL;
-    PyObject *k;
+    PyObject *k = NULL;
 
     k = PyLong_FromVoidPtr(key);
     if (k == NULL)
@@ -75,6 +75,7 @@ ste_new(struct symtable *st, identifier name, _Py_block_ty block,
 
     return ste;
  fail:
+    Py_XDECREF(k);
     Py_XDECREF(ste);
     return NULL;
 }

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ ste_new(struct symtable *st, identifier name, _Py_block_ty block,`
`22`	`22`	`void *key, int lineno)`
`23`	`23`	`{`
`24`	`24`	`PySTEntryObject *ste = NULL;`
`25`		`- PyObject *k;`
	`25`	`+ PyObject *k = NULL;`
`26`	`26`
`27`	`27`	`k = PyLong_FromVoidPtr(key);`
`28`	`28`	`if (k == NULL)`
`@@ -75,6 +75,7 @@ ste_new(struct symtable *st, identifier name, _Py_block_ty block,`
`75`	`75`
`76`	`76`	`return ste;`
`77`	`77`	`fail:`
	`78`	`+ Py_XDECREF(k);`
`78`	`79`	`Py_XDECREF(ste);`
`79`	`80`	`return NULL;`
`80`	`81`	`}`