Remove an unneeded variable and fix a little whitespace.

brettcannon · brettcannon · commit ddb882a24cda · 2010-05-05T20:26:58.000Z
Found using Clang's static analyzer.
diff --git a/Python/getcwd.c b/Python/getcwd.c
@@ -28,7 +28,7 @@ getcwd(char *buf, int size)
 {
 	char localbuf[MAXPATHLEN+1];
 	char *ret;
-	
+
 	if (size <= 0) {
 		errno = EINVAL;
 		return NULL;
@@ -59,14 +59,13 @@ getcwd(char *buf, int size)
 {
 	FILE *fp;
 	char *p;
-	int sts;
 	if (size <= 0) {
 		errno = EINVAL;
 		return NULL;
 	}
 	if ((fp = popen(PWD_CMD, "r")) == NULL)
 		return NULL;
-	if (fgets(buf, size, fp) == NULL || (sts = pclose(fp)) != 0) {
+	if (fgets(buf, size, fp) == NULL || pclose(fp) != 0) {
 		errno = EACCES; /* Most likely error */
 		return NULL;
 	}

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ getcwd(char *buf, int size)`
`28`	`28`	`{`
`29`	`29`	`char localbuf[MAXPATHLEN+1];`
`30`	`30`	`char *ret;`
`31`		`-`
	`31`	`+`
`32`	`32`	`if (size <= 0) {`
`33`	`33`	`errno = EINVAL;`
`34`	`34`	`return NULL;`
`@@ -59,14 +59,13 @@ getcwd(char *buf, int size)`
`59`	`59`	`{`
`60`	`60`	`FILE *fp;`
`61`	`61`	`char *p;`
`62`		`- int sts;`
`63`	`62`	`if (size <= 0) {`
`64`	`63`	`errno = EINVAL;`
`65`	`64`	`return NULL;`
`66`	`65`	`}`
`67`	`66`	`if ((fp = popen(PWD_CMD, "r")) == NULL)`
`68`	`67`	`return NULL;`
`69`		`- if (fgets(buf, size, fp) == NULL \|\| (sts = pclose(fp)) != 0) {`
	`68`	`+ if (fgets(buf, size, fp) == NULL \|\| pclose(fp) != 0) {`
`70`	`69`	`errno = EACCES; /* Most likely error */`
`71`	`70`	`return NULL;`
`72`	`71`	`}`