Fixed issue 5782: formatting with commas didn't work if no specifier type code was given.

ericvsmith · ericvsmith · commit c4f5aca64e78 · 2009-04-22T16:20:47.000Z
diff --git a/Lib/test/test_types.py b/Lib/test/test_types.py
@@ -405,6 +405,9 @@ def test(i, format_spec, result):
         test(123456, "#012X", '0X000001E240')
         test(-123456, "#012X", '-0X00001E240')
 
+        # issue 5782, commas with no specifier type
+        test(1234, '010,', '00,001,234')
+
         # make sure these are errors
 
         # precision disallowed
@@ -632,6 +635,9 @@ def test(f, format_spec, result):
         test(-1234.12341234, '013f', '-01234.123412')
         test(-123456.12341234, '011.2f', '-0123456.12')
 
+        # issue 5782, commas with no specifier type
+        test(1.2, '010,.2', '0,000,001.2')
+
         # 0 padding with commas
         test(1234., '011,f', '1,234.000000')
         test(1234., '012,f', '1,234.000000')
diff --git a/Objects/stringlib/formatter.h b/Objects/stringlib/formatter.h
@@ -248,6 +248,7 @@ parse_internal_render_format_spec(STRINGLIB_CHAR *format_spec,
         case 'G':
         case '%':
         case 'F':
+        case '\0':
             /* These are allowed. See PEP 378.*/
             break;
         default:
