transformation ordering fix: total order required for the comparator

Dmytro Guzenko · Dmytro Guzenko · commit f4ebf9f37ed7 · 2018-08-21T16:49:11.000-07:00
diff --git a/biojava-structure/src/main/java/org/biojava/nbio/structure/quaternary/BiologicalAssemblyBuilder.java b/biojava-structure/src/main/java/org/biojava/nbio/structure/quaternary/BiologicalAssemblyBuilder.java
@@ -144,8 +144,9 @@ public int compare(BiologicalAssemblyTransformation t1, BiologicalAssemblyTransf
 				// set sort order only if the two ids are identical
 				if (t1.getId().equals(t2.getId())) {
 					 return chainIds.indexOf(t1.getChainId()) - chainIds.indexOf(t2.getChainId());
+				} else {
+					return t1.getId().compareTo(t2.getId());
 				}
-			    return 0;
 		    }
 		});
 	}

Original file line number	Diff line number	Diff line change
`@@ -144,8 +144,9 @@ public int compare(BiologicalAssemblyTransformation t1, BiologicalAssemblyTransf`
`144`	`144`	`// set sort order only if the two ids are identical`
`145`	`145`	`if (t1.getId().equals(t2.getId())) {`
`146`	`146`	`return chainIds.indexOf(t1.getChainId()) - chainIds.indexOf(t2.getChainId());`
	`147`	`+ } else {`
	`148`	`+ return t1.getId().compareTo(t2.getId());`
`147`	`149`	`}`
`148`		`- return 0;`
`149`	`150`	`}`
`150`	`151`	`});`
`151`	`152`	`}`