Merge pull request #1089 from cinsttool/master

josemduarte · web-flow · commit e7c31d74cda5 · 2024-04-23T11:57:17.000-07:00
Fix container inefficiency in GenericFastaHeaderParser.java
diff --git a/biojava-core/src/main/java/org/biojava/nbio/core/sequence/io/GenericFastaHeaderParser.java b/biojava-core/src/main/java/org/biojava/nbio/core/sequence/io/GenericFastaHeaderParser.java
@@ -93,9 +93,9 @@ private String[] getHeaderValues(String header) {
 					sb.append(header.charAt(i));
 				}
 
-				data = new String[values.size()];
-				values.toArray(data);
 			}
+			data = new String[values.size()];
+			values.toArray(data);
 		} else {
 			data = header.split(" ");
 		}

Original file line number	Diff line number	Diff line change
`@@ -93,9 +93,9 @@ private String[] getHeaderValues(String header) {`
`93`	`93`	`sb.append(header.charAt(i));`
`94`	`94`	`}`
`95`	`95`
`96`		`- data = new String[values.size()];`
`97`		`- values.toArray(data);`
`98`	`96`	`}`
	`97`	`+ data = new String[values.size()];`
	`98`	`+ values.toArray(data);`
`99`	`99`	`} else {`
`100`	`100`	`data = header.split(" ");`
`101`	`101`	`}`