using interfaces instead of implementations

paolopavan · paolopavan · commit dd585c96724d · 2020-04-28T00:46:21.000+01:00
diff --git a/biojava-core/src/main/java/org/biojava/nbio/core/sequence/io/GenbankSequenceParser.java b/biojava-core/src/main/java/org/biojava/nbio/core/sequence/io/GenbankSequenceParser.java
@@ -51,10 +51,7 @@
 
 import java.io.BufferedReader;
 import java.io.IOException;
-import java.util.ArrayList;
-import java.util.HashMap;
-import java.util.LinkedHashMap;
-import java.util.List;
+import java.util.*;
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
 
@@ -434,18 +431,18 @@ public GenericGenbankHeaderParser<S, C> getSequenceHeaderParser() {
 		return headerParser;
 	}
 
-	public LinkedHashMap<String, ArrayList<DBReferenceInfo>> getDatabaseReferences() {
+	public Map<String, ArrayList<DBReferenceInfo>> getDatabaseReferences() {
 		return mapDB;
 	}
 
-	public ArrayList<String> getKeyWords() {
+	public List<String> getKeyWords() {
 		return new ArrayList<>(featureCollection.keySet());
 	}
 
-	public ArrayList<AbstractFeature> getFeatures(String keyword) {
+	public List<AbstractFeature> getFeatures(String keyword) {
 		return featureCollection.get(keyword);
 	}
-	public HashMap<String, ArrayList<AbstractFeature>> getFeatures() {
+	public Map<String, ArrayList<AbstractFeature>> getFeatures() {
 		return featureCollection;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -51,10 +51,7 @@`
`51`	`51`
`52`	`52`	`import java.io.BufferedReader;`
`53`	`53`	`import java.io.IOException;`
`54`		`-import java.util.ArrayList;`
`55`		`-import java.util.HashMap;`
`56`		`-import java.util.LinkedHashMap;`
`57`		`-import java.util.List;`
	`54`	`+import java.util.*;`
`58`	`55`	`import java.util.regex.Matcher;`
`59`	`56`	`import java.util.regex.Pattern;`
`60`	`57`
`@@ -434,18 +431,18 @@ public GenericGenbankHeaderParser<S, C> getSequenceHeaderParser() {`
`434`	`431`	`return headerParser;`
`435`	`432`	`}`
`436`	`433`
`437`		`- public LinkedHashMap<String, ArrayList<DBReferenceInfo>> getDatabaseReferences() {`
	`434`	`+ public Map<String, ArrayList<DBReferenceInfo>> getDatabaseReferences() {`
`438`	`435`	`return mapDB;`
`439`	`436`	`}`
`440`	`437`
`441`		`- public ArrayList<String> getKeyWords() {`
	`438`	`+ public List<String> getKeyWords() {`
`442`	`439`	`return new ArrayList<>(featureCollection.keySet());`
`443`	`440`	`}`
`444`	`441`
`445`		`- public ArrayList<AbstractFeature> getFeatures(String keyword) {`
	`442`	`+ public List<AbstractFeature> getFeatures(String keyword) {`
`446`	`443`	`return featureCollection.get(keyword);`
`447`	`444`	`}`
`448`		`- public HashMap<String, ArrayList<AbstractFeature>> getFeatures() {`
	`445`	`+ public Map<String, ArrayList<AbstractFeature>> getFeatures() {`
`449`	`446`	`return featureCollection;`
`450`	`447`	`}`
`451`	`448`