Fixing some minor warnings

sbliven · sbliven · commit c9af1d7117f6 · 2015-12-03T13:16:57.000+01:00
diff --git a/biojava-core/src/main/java/org/biojava/nbio/core/sequence/loader/GenbankProxySequenceReader.java b/biojava-core/src/main/java/org/biojava/nbio/core/sequence/loader/GenbankProxySequenceReader.java
@@ -170,7 +170,8 @@ public String getHeader() {
     public GenericGenbankHeaderParser<AbstractSequence<C>, C> getHeaderParser() {
         return headerParser;
     }
-    public HashMap<String, ArrayList<AbstractFeature>> getFeatures() {
+    @Override
+	public HashMap<String, ArrayList<AbstractFeature>> getFeatures() {
         return features;
     }
 
diff --git a/biojava-core/src/main/java/org/biojava/nbio/core/util/InputStreamProvider.java b/biojava-core/src/main/java/org/biojava/nbio/core/util/InputStreamProvider.java
@@ -184,8 +184,7 @@ else if ( fileName.endsWith(".gz")) {
 
       else if ( fileName.endsWith(".zip")){
 
-         @SuppressWarnings("resource")
-		ZipFile zipfile = new ZipFile(f);
+         ZipFile zipfile = new ZipFile(f);
 
          // stream to first entry is returned ...
          ZipEntry entry;
@@ -201,8 +200,7 @@ else if ( fileName.endsWith(".zip")){
 
       else if ( fileName.endsWith(".jar")) {
 
-         @SuppressWarnings("resource")
-		JarFile jarFile = new JarFile(f);
+         JarFile jarFile = new JarFile(f);
 
          // stream to first entry is returned
          JarEntry entry;
diff --git a/biojava-core/src/test/java/org/biojava/nbio/core/search/io/HspTest.java b/biojava-core/src/test/java/org/biojava/nbio/core/search/io/HspTest.java
@@ -30,7 +30,6 @@
 import org.junit.BeforeClass;
 import org.junit.Test;
 import static org.junit.Assert.*;
-import org.junit.Ignore;
 
 /**
  * @author Paolo Pavan
diff --git a/biojava-core/src/test/java/org/biojava/nbio/core/sequence/io/FastaReaderTest.java b/biojava-core/src/test/java/org/biojava/nbio/core/sequence/io/FastaReaderTest.java
@@ -36,9 +36,6 @@
 import java.util.LinkedHashMap;
 import java.util.logging.Level;
 
-import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertNotNull;
-
 /**
  *
  * @author Scooter Willis <willishf at gmail dot com>
@@ -58,10 +55,12 @@ public static void setUpClass() throws Exception {
 	public static void tearDownClass() throws Exception {
 	}
 
+	@Override
 	@Before
 	public void setUp() {
 	}
 
+	@Override
 	@After
 	public void tearDown() {
 	}
diff --git a/biojava-core/src/test/java/org/biojava/nbio/core/sequence/io/GenbankCookbookTest.java b/biojava-core/src/test/java/org/biojava/nbio/core/sequence/io/GenbankCookbookTest.java
@@ -36,8 +36,6 @@
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-import java.io.File;
-import java.io.FileInputStream;
 import java.util.LinkedHashMap;
 
 /**
diff --git a/biojava-core/src/test/java/org/biojava/nbio/core/sequence/loader/GenbankProxySequenceReaderTest.java b/biojava-core/src/test/java/org/biojava/nbio/core/sequence/loader/GenbankProxySequenceReaderTest.java
@@ -39,7 +39,6 @@
 import java.util.Collection;
 import org.biojava.nbio.core.sequence.features.AbstractFeature;
 import org.biojava.nbio.core.sequence.features.Qualifier;
-import org.junit.Ignore;
 
 /**
  * Testing example for issue #834

Original file line number	Diff line number	Diff line change
`@@ -170,7 +170,8 @@ public String getHeader() {`
`170`	`170`	`public GenericGenbankHeaderParser<AbstractSequence<C>, C> getHeaderParser() {`
`171`	`171`	`return headerParser;`
`172`	`172`	`}`
`173`		`- public HashMap<String, ArrayList<AbstractFeature>> getFeatures() {`
	`173`	`+ @Override`
	`174`	`+ public HashMap<String, ArrayList<AbstractFeature>> getFeatures() {`
`174`	`175`	`return features;`
`175`	`176`	`}`
`176`	`177`
Original file line number	Diff line number	Diff line change
`@@ -36,9 +36,6 @@`
`36`	`36`	`import java.util.LinkedHashMap;`
`37`	`37`	`import java.util.logging.Level;`
`38`	`38`
`39`		`-import static org.junit.Assert.assertEquals;`
`40`		`-import static org.junit.Assert.assertNotNull;`
`41`		`-`
`42`	`39`	`/**`
`43`	`40`	`*`
`44`	`41`	`* @author Scooter Willis <willishf at gmail dot com>`
`@@ -58,10 +55,12 @@ public static void setUpClass() throws Exception {`
`58`	`55`	`public static void tearDownClass() throws Exception {`
`59`	`56`	`}`
`60`	`57`
	`58`	`+ @Override`
`61`	`59`	`@Before`
`62`	`60`	`public void setUp() {`
`63`	`61`	`}`
`64`	`62`
	`63`	`+ @Override`
`65`	`64`	`@After`
`66`	`65`	`public void tearDown() {`
`67`	`66`	`}`