Merge pull request #925 from MaxGreil/GithubIssue864

josemduarte · web-flow · commit 88f8e476ea52 · 2021-03-13T00:16:19.000-08:00
Fix issue 864
diff --git a/biojava-structure/src/main/java/org/biojava/nbio/structure/align/pairwise/AltAligComparator.java b/biojava-structure/src/main/java/org/biojava/nbio/structure/align/pairwise/AltAligComparator.java
@@ -43,20 +43,15 @@ public int compare(AlternativeAlignment a, AlternativeAlignment b) {
 
 		if ( s1 > s2)
 			return 1;
-		if ( s1 < s2)
+		else if ( s1 < s2)
 			return -1;
+		else {
+			// seem to have the same length
+			double rms1 = a.getRmsd();
+			double rms2 = b.getRmsd();
+			return Double.compare(rms1, rms2);
+		}
 
-		// seem to have the same length
-
-		double rms1 = a.getRmsd();
-		double rms2 = b.getRmsd();
-
-		if ( rms1 < rms2)
-			return 1;
-		if ( rms1 < rms2)
-			return -1;
-
-		return 0;
 	}
 
 
