Skip to content

Commit 402c177

Browse files
committed
Logging and documentation
1 parent ea78f97 commit 402c177

File tree

2 files changed

+10
-5
lines changed

2 files changed

+10
-5
lines changed

biojava-structure-gui/src/main/java/org/biojava/nbio/structure/align/gui/jmol/AbstractAlignmentJmol.java

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,8 @@
4141
import org.biojava.nbio.structure.jama.Matrix;
4242
import org.jcolorbrewer.ColorBrewer;
4343
import org.jmol.api.JmolViewer;
44+
import org.slf4j.Logger;
45+
import org.slf4j.LoggerFactory;
4446

4547
/**
4648
* An Abstract Class to generalize the visualization of AFP and
@@ -52,6 +54,7 @@
5254
public abstract class AbstractAlignmentJmol
5355
implements MouseMotionListener, MouseListener, WindowListener, ActionListener {
5456

57+
private static final Logger logger = LoggerFactory.getLogger(AbstractAlignmentJmol.class);
5558
protected Structure structure;
5659
protected ColorBrewer colorPalette = ColorBrewer.Spectral;
5760

@@ -81,7 +84,7 @@ public abstract class AbstractAlignmentJmol
8184
* Set all the member variables to null.
8285
*/
8386
public void destroy(){
84-
System.err.println("cleaning up AlignmentJmol window");
87+
logger.debug("cleaning up AlignmentJmol window");
8588
jmolPanel.removeMouseListener(this);
8689
jmolPanel.removeMouseMotionListener(this);
8790
jmolPanel.destroy();
@@ -135,7 +138,7 @@ public void setJmolPanel(JmolPanel jmolPanel) {
135138
*/
136139
public void evalString(String rasmolScript){
137140
if ( jmolPanel == null ){
138-
System.err.println("please install Jmol first");
141+
logger.error("please install Jmol first");
139142
return;
140143
}
141144
jmolPanel.evalString(rasmolScript);
@@ -148,7 +151,7 @@ public void evalString(String rasmolScript){
148151
public void setStructure(Structure s) {
149152

150153
if (jmolPanel == null){
151-
System.err.println("please install Jmol first");
154+
logger.error("please install Jmol first");
152155
return;
153156
}
154157
setTitle(s.getPDBCode());

biojava-structure/src/main/java/org/biojava/nbio/structure/symmetry/internal/CESymmParameters.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,9 @@ public List<String> getUserConfigHelp() {
222222
+ "between two aligned residues.");
223223

224224
// gaps
225-
params.add("MStA Gaps: allow gaps in the multiple alignment if true.");
225+
params.add("Internal Gaps: allow up to 50% of repeats to have gaps in "
226+
+ "the multiple alignment if true, "
227+
+ "otherwise all repeats must be aligned at each position.");
226228

227229
// optimization steps
228230
params.add("Optimization Steps: maximum number of optimization steps:"
@@ -266,7 +268,7 @@ public List<String> getUserConfigParameterNames() {
266268
params.add("SSE Threshold");
267269
params.add("Minimum Core Length");
268270
params.add("Distance Cutoff");
269-
params.add("MStA Gaps");
271+
params.add("Internal Gaps");
270272
params.add("Optimization Steps");
271273
return params;
272274
}

0 commit comments

Comments
 (0)