fix: resolve exception when action ID is passed to printer formatter

nats · nats · commit 18c3eac56177 · 2025-03-05T17:20:03.000+10:00
diff --git a/src/binarylane/console/printers/formatter.py b/src/binarylane/console/printers/formatter.py
@@ -33,7 +33,9 @@ def object_to_list(row: Dict[str, Any], columns: List[str]) -> List[Any]:
     if isinstance(response, str):
         data = [[DEFAULT_HEADING]] if show_header else []
         data += [[response]]
-
+    elif isinstance(response, int):
+        data = [[DEFAULT_HEADING]] if show_header else []
+        data += [[str(response)]]
     else:
         data = [["name", "value"]] if show_header else []
         data += [_flatten(item, True) for item in response.to_dict().items()]
diff --git a/src/binarylane/console/printers/json_printer.py b/src/binarylane/console/printers/json_printer.py
@@ -10,4 +10,7 @@ class JsonPrinter(Printer):
     """Output an API response as 'raw' JSON"""
 
     def print(self, response: Any, fields: Optional[List[str]] = None) -> None:
-        print(json.dumps(response.to_dict()))
+        print(self.format_response(response))
+
+    def format_response(self, response: Any) -> str:
+        return json.dumps(response.to_dict() if hasattr(response, "to_dict") else response)
diff --git a/tests/printers/test_formatter.py b/tests/printers/test_formatter.py
@@ -93,3 +93,9 @@ def test_format_networks_v4_and_v6(servers_response: ServersResponse) -> None:
         Network(ip_address="value4", type=NetworkType.PUBLIC),
     ]
     assert formatter.format_response(servers_response, False, ["networks"]) == [["ipv4\nipv6"]]
+
+
+# ActionLinkRunner when used with --async will print the action ID
+def test_format_int() -> None:
+    assert formatter.format_response(12345, True) == [[formatter.DEFAULT_HEADING], ["12345"]]
+    assert formatter.format_response(12345, False) == [["12345"]]
diff --git a/tests/printers/test_json.py b/tests/printers/test_json.py
@@ -0,0 +1,40 @@
+from __future__ import annotations
+
+from typing import Any, Dict, List
+
+from binarylane.console.printers.json_printer import JsonPrinter
+
+printer = JsonPrinter()
+
+
+def test_format_str() -> None:
+    assert printer.format_response("test") == '"test"'
+
+
+def test_format_list() -> None:
+    ns1 = "ns1.binarylane.com.au"
+    ns2 = "ns2.binarylane.com.au"
+    dns = [ns1, ns2]
+
+    assert printer.format_response(dns) == '["ns1.binarylane.com.au", "ns2.binarylane.com.au"]'
+
+
+def test_format_dict() -> None:
+    class DnsList:
+        dns: List[str]
+        meta: Dict[str, Any]
+        links: List[str]
+
+        def __init__(self) -> None:
+            self.dns = ["ns1.binarylane.com.au", "ns2.binarylane.com.au"]
+
+        def to_dict(self) -> Dict[str, Any]:
+            return {"dns": self.dns}
+
+    response = DnsList()
+    assert printer.format_response(response) == '{"dns": ["ns1.binarylane.com.au", "ns2.binarylane.com.au"]}'
+
+
+# ActionLinkRunner when used with --async will print the action ID
+def test_format_int() -> None:
+    assert printer.format_response(12345) == "12345"
