src: honor --abort_on_uncaught_exception flag

evanlucas · evanlucas · commit 921f2de6cf99 · 2015-09-17T15:25:25.000-05:00
Fix regression introduced in 0af4c9e that ignores the --abort-on-uncaught-exception flag. Prior to that commit, the flag was passed through to v8. After that commit, the process just calls exit(1). PR-URL: nodejs#2776 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-by: Trevor Norris <trev.norris@gmail.com>
diff --git a/src/node.cc b/src/node.cc
@@ -2180,7 +2180,11 @@ void FatalException(Isolate* isolate,
 
   if (false == caught->BooleanValue()) {
     ReportException(env, error, message);
-    exit(1);
+    if (abort_on_uncaught_exception) {
+      ABORT();
+    } else {
+      exit(1);
+    }
   }
 }
 
diff --git a/test/abort/test-abort-uncaught-exception.js b/test/abort/test-abort-uncaught-exception.js
@@ -0,0 +1,31 @@
+'use strict';
+
+const common = require('../common');
+const assert = require('assert');
+const spawn = require('child_process').spawn;
+const node = process.execPath;
+
+if (process.argv[2] === 'child') {
+  throw new Error('child error');
+} else {
+  run('', null);
+  run('--abort-on-uncaught-exception', 'SIGABRT');
+}
+
+function run(flags, signal) {
+  const args = [__filename, 'child'];
+  if (flags)
+    args.unshift(flags);
+
+  const child = spawn(node, args);
+  child.on('exit', common.mustCall(function(code, sig) {
+    if (!common.isWindows) {
+      assert.strictEqual(sig, signal);
+    } else {
+      if (signal)
+        assert.strictEqual(code, 3);
+      else
+        assert.strictEqual(code, 1);
+    }
+  }));
+}

Original file line number	Diff line number	Diff line change
`@@ -2180,7 +2180,11 @@ void FatalException(Isolate* isolate,`
`2180`	`2180`
`2181`	`2181`	`if (false == caught->BooleanValue()) {`
`2182`	`2182`	`ReportException(env, error, message);`
`2183`		`- exit(1);`
	`2183`	`+ if (abort_on_uncaught_exception) {`
	`2184`	`+ ABORT();`
	`2185`	`+ } else {`
	`2186`	`+ exit(1);`
	`2187`	`+ }`
`2184`	`2188`	`}`
`2185`	`2189`	`}`
`2186`	`2190`