Fix findbugs warning in Script.java Unnecessary boxing/unboxing of int value

rsafonseca · yadvr · commit a4659d009e29 · 2015-06-15T12:10:00.000+03:00
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com> This closes apache#436
diff --git a/utils/src/com/cloud/utils/script/Script.java b/utils/src/com/cloud/utils/script/Script.java
@@ -492,7 +492,7 @@ public static int runSimpleBashScriptForExitValue(String command, int timeout) {
             return -1;
         else {
             try {
-                return Integer.valueOf(result.trim());
+                return Integer.parseInt(result.trim());
             } catch (NumberFormatException e) {
                 return -1;
             }

Original file line number	Diff line number	Diff line change
`@@ -492,7 +492,7 @@ public static int runSimpleBashScriptForExitValue(String command, int timeout) {`
`492`	`492`	`return -1;`
`493`	`493`	`else {`
`494`	`494`	`try {`
`495`		`- return Integer.valueOf(result.trim());`
	`495`	`+ return Integer.parseInt(result.trim());`
`496`	`496`	`} catch (NumberFormatException e) {`
`497`	`497`	`return -1;`
`498`	`498`	`}`