Fix findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING warning in Upgrade410to420.java

rsafonseca · DaanHoogland · commit 53e42fb45e87 · 2015-06-22T10:55:29.000+02:00
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com> This closes apache#505
diff --git a/engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java b/engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java
@@ -692,9 +692,10 @@ private void upgradeVmwareLabels(Connection conn) {
                         try(ResultSet rsLabel = sel_pstmt.executeQuery();) {
                             newLabel = getNewLabel(rsLabel, trafficTypeVswitchParamValue);
                             try(PreparedStatement update_pstmt =
-                                    conn.prepareStatement("update physical_network_traffic_types set vmware_network_label = " + newLabel + " where traffic_type = '" + trafficType +
-                                            "' and vmware_network_label is not NULL;");) {
+                                    conn.prepareStatement("update physical_network_traffic_types set vmware_network_label = ? where traffic_type = ? and vmware_network_label is not NULL;");) {
                                 s_logger.debug("Updating vmware label for " + trafficType + " traffic. Update SQL statement is " + pstmt);
+                                pstmt.setString(1, newLabel);
+                                pstmt.setString(2, trafficType);
                                 update_pstmt.executeUpdate();
                             }catch (SQLException e) {
                                 throw new CloudRuntimeException("Unable to set vmware traffic labels ", e);
