Skip venv tests for 2.7 and disable fail fast (#11546)

karthiknadig · web-flow · commit e5ba13f78794 · 2020-05-04T09:25:25.000-07:00
* Skip venv tests for 2.7 and disable fail fast * Use isPythonVersion * Remove CI_PYTHON_VERSION env setting * Revert "Remove CI_PYTHON_VERSION env setting" This reverts commit d7c7567. * Revert "Use isPythonVersion" This reverts commit 06f3a81.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -383,6 +383,7 @@ jobs:
       - name: Run venv tests
         env:
           TEST_FILES_SUFFIX: testvirtualenvs
+          CI_PYTHON_VERSION: ${{matrix.python}}
         uses: GabrielBB/xvfb-action@v1.0
         with:
           run: npm run testSingleWorkspace
diff --git a/src/test/common/terminals/environmentActivationProviders/terminalActivation.testvirtualenvs.ts b/src/test/common/terminals/environmentActivationProviders/terminalActivation.testvirtualenvs.ts
@@ -171,7 +171,11 @@ suite('Activation of Environments in Terminal', () => {
         expect(fileSystem.arePathsSame(content, PYTHON_PATH)).to.equal(false, 'Environment not activated');
     });
 
-    test('Should activate with venv', async () => {
+    test('Should activate with venv', async function () {
+        if (process.env.CI_PYTHON_VERSION && process.env.CI_PYTHON_VERSION.startsWith('2.')) {
+            // tslint:disable-next-line: no-invalid-this
+            this.skip();
+        }
         await testActivation(envPaths.venvPath);
     });
     test('Should activate with pipenv', async () => {
