Skip to content

Commit 2ebe9d6

Browse files
committed
Fix node-tests on OSX by explicitly requiring modules with relative paths.
1 parent b812411 commit 2ebe9d6

File tree

4 files changed

+13
-10
lines changed

4 files changed

+13
-10
lines changed

gruntfile.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ module.exports = function(grunt) {
152152
};
153153

154154
var nodeTestEnv = JSON.parse(JSON.stringify(process.env));
155-
nodeTestEnv.NODE_PATH = localCfg.outTnsCoreModules
155+
nodeTestEnv.NODE_PATH = localCfg.outTnsCoreModules;
156156

157157
localCfg.nodeTestsDir = path.join(localCfg.outDir, 'node-tests');
158158

@@ -546,10 +546,10 @@ module.exports = function(grunt) {
546546
grunt.file.write(combinedDtsPath, dtsLines.join('\n'));
547547
}
548548
function generateModulesDts(outDir) {
549-
var angularConflicts = ['module.d.ts']
549+
var angularConflicts = ['module.d.ts'];
550550
var angularExcludes = angularConflicts.map(function(file) {
551551
return '!' + file;
552-
})
552+
});
553553
var nonES6Files = [
554554
'es-collections.d.ts',
555555
'es6-promise.d.ts',
@@ -558,7 +558,7 @@ module.exports = function(grunt) {
558558
];
559559
var es6Excludes = nonES6Files.map(function(file) {
560560
return '!' + file;
561-
})
561+
});
562562
var dtsFiles = grunt.file.expand({cwd: localCfg.outTnsCoreModules }, [
563563
"**/*.d.ts",
564564
//Exclude the d.ts files in the apps folder - these are part of the apps and are already packed there!
@@ -582,8 +582,8 @@ module.exports = function(grunt) {
582582
writeDtsFile(es6Files, outDir, 'tns-core-modules/tns-core-modules.es6.d.ts');
583583
var allFiles = angularConflicts.concat(nonES6Files).concat(['tns-core-modules.base.d.ts']);
584584
writeDtsFile(allFiles, outDir, 'tns-core-modules/tns-core-modules.d.ts');
585-
};
586-
585+
}
586+
587587
grunt.registerTask("processTestsApp", function(outTestsAppDir, pkgAppNameSuffix) {
588588
var tasks = [
589589
{

node-tests/node-shims.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
declare var require: any;

node-tests/test-angular-xml.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,14 @@
11
import {assert} from "chai";
2-
import xml = require('xml');
2+
import * as xmlModule from "xml";
3+
var xml: typeof xmlModule = require("../tns-core-modules/xml");
34

45
describe("angular xml parser", () => {
56
let last_element = null;
67
let last_attrs = null;
78
let parser = null;
89

910
beforeEach(() => {
10-
parser = new xml.XmlParser(function (event: xml.ParserEvent) {
11+
parser = new xml.XmlParser(function (event: xmlModule.ParserEvent) {
1112
switch (event.eventType) {
1213
case xml.ParserEventType.StartElement:
1314
last_element = event.elementName;

node-tests/test-xml.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import {assert} from "chai";
2-
import xml = require('xml');
2+
import * as xmlModule from "xml";
3+
var xml: typeof xmlModule = require("../tns-core-modules/xml");
34

45
describe("xml parser", () => {
56
let last_element = null;
@@ -8,7 +9,7 @@ describe("xml parser", () => {
89
let parser = null;
910

1011
beforeEach(() => {
11-
parser = new xml.XmlParser(function (event: xml.ParserEvent) {
12+
parser = new xml.XmlParser(function (event: xmlModule.ParserEvent) {
1213
switch (event.eventType) {
1314
case xml.ParserEventType.StartElement:
1415
last_element = event.elementName;

0 commit comments

Comments
 (0)