Remove spurious 'job_id' property.

tseaver · tseaver · commit d9d5bd2c61a1 · 2016-02-15T15:26:51.000-05:00
The user-assigned 'name' is what is needed. Fixes googleapis#1399.
diff --git a/docs/bigquery-usage.rst b/docs/bigquery-usage.rst
@@ -279,8 +279,8 @@ List jobs for a project:
    >>> from gcloud import bigquery
    >>> client = bigquery.Client()
    >>> jobs, token = client.list_jobs()  # API request
-   >>> [(job.job_id, job.type, job.created, job.state) for job in jobs]
-   ['e3344fba-09df-4ae0-8337-fddee34b3840', 'load', (datetime.datetime(2015, 7, 23, 9, 30, 20, 268260, tzinfo=<UTC>), 'done')]
+   >>> [(job.nme, job.type, job.created, job.state) for job in jobs]
+   ['load-table-job', 'load', (datetime.datetime(2015, 7, 23, 9, 30, 20, 268260, tzinfo=<UTC>), 'done')]
 
 Querying data (synchronous)
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~
@@ -331,8 +331,8 @@ Background a query, loading the results into a table:
    >>> job = client.run_async_query('fullname-age-query-job', query)
    >>> job.destination_table = table
    >>> job.write_disposition= 'truncate'
-   >>> job.job_id
-   'e3344fba-09df-4ae0-8337-fddee34b3840'
+   >>> job.name
+   'fullname-age-query-job'
    >>> job.type
    'query'
    >>> job.created
@@ -412,8 +412,8 @@ the job locally:
    >>> job.source_format = 'CSV'
    >>> job.skip_leading_rows = 1  # count of skipped header rows
    >>> job.write_disposition = 'truncate'
-   >>> job.job_id
-   'e3344fba-09df-4ae0-8337-fddee34b3840'
+   >>> job.name
+   'load-from-storage-job'
    >>> job.type
    'load'
    >>> job.created
@@ -469,8 +469,8 @@ located on Google Cloud Storage.  First, create the job locally:
    ... job.destination_format = 'CSV'
    ... job.print_header = True
    ... job.write_disposition = 'truncate'
-   >>> job.job_id
-   'e3344fba-09df-4ae0-8337-fddee34b3840'
+   >>> job.name
+   'extract-person-ages-job'
    >>> job.type
    'extract'
    >>> job.created
@@ -523,8 +523,8 @@ First, create the job locally:
    >>> destination_table = dataset.table(name='person_ages_copy')
    >>> job = client.copy_table(
    ...     'copy-table-job', destination_table, source_table)
-   >>> job.job_id
-   'e3344fba-09df-4ae0-8337-fddee34b3840'
+   >>> job.name
+   'copy-table-job'
    >>> job.type
    'copy'
    >>> job.created
diff --git a/gcloud/bigquery/test_job.py b/gcloud/bigquery/test_job.py
@@ -71,7 +71,6 @@ def _makeResource(self, started=False, ended=False):
     def _verifyInitialReadonlyProperties(self, job):
         # root elements of resource
         self.assertEqual(job.etag, None)
-        self.assertEqual(job.job_id, None)
         self.assertEqual(job.self_link, None)
         self.assertEqual(job.user_email, None)
 
@@ -88,8 +87,6 @@ def _verifyInitialReadonlyProperties(self, job):
     def _verifyReadonlyResourceProperties(self, job, resource):
         from datetime import timedelta
 
-        self.assertEqual(job.job_id, self.JOB_ID)
-
         statistics = resource.get('statistics', {})
 
         if 'creationTime' in statistics:
@@ -337,7 +334,6 @@ def test_props_set_by_server(self):
         load_stats['outputRows'] = 345
 
         self.assertEqual(job.etag, 'ETAG')
-        self.assertEqual(job.job_id, JOB_ID)
         self.assertEqual(job.self_link, URL)
         self.assertEqual(job.user_email, EMAIL)
 
