Skip to content

Commit cf05309

Browse files
committed
Actually remove 'Job.job_id' property.
1 parent 52ed5a8 commit cf05309

2 files changed

Lines changed: 2 additions & 11 deletions

File tree

gcloud/bigquery/job.py

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -155,15 +155,6 @@ def etag(self):
155155
"""
156156
return self._properties.get('etag')
157157

158-
@property
159-
def job_id(self):
160-
"""ID for the job resource.
161-
162-
:rtype: string, or ``NoneType``
163-
:returns: the ID (None until set from the server).
164-
"""
165-
return self._properties.get('id')
166-
167158
@property
168159
def self_link(self):
169160
"""URL for the job resource.

gcloud/bigquery/test_client.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,7 @@ def test_list_jobs_defaults(self):
233233
for found, expected in zip(jobs, DATA['jobs']):
234234
name = expected['jobReference']['jobId']
235235
self.assertTrue(isinstance(found, JOB_TYPES[name]))
236-
self.assertEqual(found.job_id, expected['id'])
236+
self.assertEqual(found.name, name)
237237
self.assertEqual(token, TOKEN)
238238

239239
self.assertEqual(len(conn._requested), 1)
@@ -285,7 +285,7 @@ def test_list_jobs_load_job_wo_sourceUris(self):
285285
for found, expected in zip(jobs, DATA['jobs']):
286286
name = expected['jobReference']['jobId']
287287
self.assertTrue(isinstance(found, JOB_TYPES[name]))
288-
self.assertEqual(found.job_id, expected['id'])
288+
self.assertEqual(found.name, name)
289289
self.assertEqual(token, TOKEN)
290290

291291
self.assertEqual(len(conn._requested), 1)

0 commit comments

Comments
 (0)