Fixed a crash in prerelease mode when a package misses the version field in its package.json (changesets#1589)

remorses · vzt7 · Andarist · web-flow · commit de8bebc93b81 · 2025-05-05T10:51:43.000+02:00
* Fixed the prerelease version parse

* ignore packages without version

* fix tsc errors

* add changeset

* tweak

* Update .changeset/chilly-nights-repair.md

---------

Co-authored-by: vzt7 &lt;vzt7.zed@gmail.com&gt;
Co-authored-by: Mateusz Burzyński &lt;mateuszburzynski@gmail.com&gt;
diff --git a/.changeset/chilly-nights-repair.md b/.changeset/chilly-nights-repair.md
@@ -0,0 +1,9 @@
+---
+"@changesets/assemble-release-plan": patch
+"@changesets/cli": patch
+---
+
+author: @remorses
+author: @vzt7
+
+Fixed a crash in prerelease mode when a package misses the version field in its `package.json`
diff --git a/packages/assemble-release-plan/src/index.ts b/packages/assemble-release-plan/src/index.ts
@@ -358,6 +358,14 @@ function getPreInfo(
   // preVersion is the map between package name and its next pre version number.
   let preVersions = new Map<string, number>();
   for (const [, pkg] of packagesByName) {
+    if (
+      shouldSkipPackage(pkg, {
+        ignore: config.ignore,
+        allowPrivatePackages: config.privatePackages.tag,
+      })
+    ) {
+      continue;
+    }
     preVersions.set(
       pkg.packageJson.name,
       getPreVersion(pkg.packageJson.version)
diff --git a/packages/cli/src/commands/version/version.test.ts b/packages/cli/src/commands/version/version.test.ts
@@ -2990,6 +2990,44 @@ describe("pre", () => {
     `);
   });
 
+  it("should version successfully when skipping a private package without a version field", async () => {
+    const cwd = await testdir({
+      "package.json": JSON.stringify({
+        private: true,
+        workspaces: ["packages/*"],
+      }),
+      "packages/pkg-a/package.json": JSON.stringify({
+        name: "pkg-a",
+        private: true,
+        // no version
+      }),
+      "packages/pkg-b/package.json": JSON.stringify({
+        name: "pkg-b",
+        version: "1.0.0",
+      }),
+    });
+    await pre(cwd, { command: "enter", tag: "next" });
+    await writeChangeset(
+      {
+        releases: [{ name: "pkg-b", type: "patch" }],
+        summary: "a very useful summary for the first change",
+      },
+      cwd
+    );
+    await version(cwd, defaultOptions, modifiedDefaultConfig);
+    let packages = (await getPackages(cwd))!;
+    expect(packages.packages.map((x) => x.packageJson)).toEqual([
+      {
+        name: "pkg-a",
+        private: true,
+      },
+      {
+        name: "pkg-b",
+        version: "1.0.1-next.0",
+      },
+    ]);
+  });
+
   describe("linked", () => {
     it("should work with linked", async () => {
       let linkedConfig = {
