Skip to content

Commit cbc6240

Browse files
Revert default python3 version to 3.6 (GoogleCloudPlatform#215)
1 parent 629ffc5 commit cbc6240

File tree

5 files changed

+7
-7
lines changed

5 files changed

+7
-7
lines changed

builder/gen-dockerfile/Dockerfile.in

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
FROM ${STAGING_IMAGE}
2-
LABEL python_version=python3.7
3-
RUN virtualenv --no-download /env -p python3.7
2+
LABEL python_version=python3.6
3+
RUN virtualenv --no-download /env -p python3.6
44

55
# Set virtualenv environment variables. This is equivalent to running
66
# source /env/bin/activate

scripts/gen_dockerfile.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@
5050
PYTHON_INTERPRETER_VERSION_MAP = {
5151
'': '', # == 2.7
5252
'2': '', # == 2.7
53-
'3': '3.7',
53+
'3': '3.6',
5454
'3.4': '3.4',
5555
'3.5': '3.5',
5656
'3.6': '3.6',

scripts/gen_dockerfile_test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ def compare_file(filename, dir1, dir2):
7171
'dockerfile_python_version': '',
7272
}),
7373
('runtime_config:\n python_version: 3', {
74-
'dockerfile_python_version': '3.7',
74+
'dockerfile_python_version': '3.6',
7575
}),
7676
('runtime_config:\n python_version: 3.4', {
7777
'dockerfile_python_version': '3.4',

scripts/testdata/hello_world_golden/Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
FROM gcr.io/google-appengine/python
2-
LABEL python_version=python3.7
3-
RUN virtualenv --no-download /env -p python3.7
2+
LABEL python_version=python3.6
3+
RUN virtualenv --no-download /env -p python3.6
44

55
# Set virtualenv environment variables. This is equivalent to running
66
# source /env/bin/activate

tests/no-virtualenv/no-virtualenv.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ commandTests:
4343
expectedOutput: ["/usr/local/bin/python3\n"]
4444
- name: "default python3 version"
4545
command: ["python3", "--version"]
46-
expectedOutput: ["Python 3.7.2\n"]
46+
expectedOutput: ["Python 3.6.8\n"]
4747
- name: "default pip3 installation"
4848
command: ["which", "pip3"]
4949
expectedOutput: ["/usr/local/bin/pip3\n"]

0 commit comments

Comments
 (0)