Skip to content

Commit 9f6233a

Browse files
author
Doug Greiman
committed
Rename GOOGLE_APPLICATIONS_CREDENTIALS.
Changed to GOOGLE_APPLICATIONS_CREDENTIALS_FOR_TESTS to match the handling of GOOGLE_CLOUD_PROJECT.
1 parent 7bee8a7 commit 9f6233a

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

RELEASING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ TAG
1515
: The suffix applied to all images created. This should be unique. If not
1616
specified, the current time will be used (timestamp format `YYYY-mm-dd-HHMMSS`).
1717

18-
GOOGLE_APPLICATION_CREDENTIALS
18+
GOOGLE_APPLICATION_CREDENTIALS_FOR_TESTS
1919
: (System test only) Path to service account credentials in JSON format.
2020

2121
GOOGLE_CLOUD_PROJECT_FOR_TESTS

build.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -97,8 +97,8 @@ fi
9797

9898
# Read action-specific environment variables
9999
if [ "${system_tests}" -eq 1 ]; then
100-
if [ -z "${GOOGLE_APPLICATION_CREDENTIALS+set}" ] ; then
101-
fatal 'Error: $GOOGLE_APPLICATION_CREDENTIALS is not set; invoke with something like GOOGLE_APPLICATION_CREDENTIALS=/path/to/service/account/creds.json'
100+
if [ -z "${GOOGLE_APPLICATION_CREDENTIALS_FOR_TESTS+set}" ] ; then
101+
fatal 'Error: $GOOGLE_APPLICATION_CREDENTIALS_FOR_TESTS is not set; invoke with something like GOOGLE_APPLICATION_CREDENTIALS_FOR_TESTS=/path/to/service/account/creds.json'
102102
fi
103103

104104
if [ -z "${GOOGLE_CLOUD_PROJECT_FOR_TESTS+set}" ] ; then
@@ -139,7 +139,7 @@ if [ "${system_tests}" -eq 1 ]; then
139139
echo "Running system tests using project ${GOOGLE_CLOUD_PROJECT_FOR_TESTS}"
140140

141141
trap "rm -f tests/google-cloud-python-system/credentials.json" EXIT
142-
cp "${GOOGLE_APPLICATION_CREDENTIALS}" tests/google-cloud-python-system/credentials.json
142+
cp "${GOOGLE_APPLICATION_CREDENTIALS_FOR_TESTS}" tests/google-cloud-python-system/credentials.json
143143
${gcloud_cmd} --config cloudbuild_system_tests.yaml --substitutions "${substitutions}" || \
144144
exit_code=1
145145
rm -f tests/google-cloud-python-system/credentials.json

0 commit comments

Comments
 (0)