Skip to content

Commit 3c14506

Browse files
author
Doug Greiman
committed
Switch default Python 3 from 3.5 to 3.6
The gen_dockerfile_test.test_generate_dockerfile_golden fails, as expected, until the corresponding XRT change is released in gcloud.
1 parent d4bc054 commit 3c14506

File tree

4 files changed

+9
-6
lines changed

4 files changed

+9
-6
lines changed

builder/gen-dockerfile/Dockerfile.in

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
FROM ${STAGING_IMAGE}
2-
LABEL python_version=python3.5
3-
RUN virtualenv --no-download /env -p python3.5
2+
LABEL python_version=python3.6
3+
RUN virtualenv --no-download /env -p python3.6
44

55
# Set virtualenv environment variables. This is equivalent to running
66
# source /env/bin/activate

scripts/gen_dockerfile.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@
5151
PYTHON_INTERPRETER_VERSION_MAP = {
5252
'': '', # == 2.7
5353
'2': '', # == 2.7
54-
'3': '3.5',
54+
'3': '3.6',
5555
'3.4': '3.4',
5656
'3.5': '3.5',
5757
'3.6': '3.6',

scripts/gen_dockerfile_test.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,14 +63,17 @@ def compare_file(filename, dir1, dir2):
6363
'dockerfile_python_version': '',
6464
}),
6565
('runtime_config:\n python_version: 3', {
66-
'dockerfile_python_version': '3.5',
66+
'dockerfile_python_version': '3.6',
6767
}),
6868
('runtime_config:\n python_version: 3.4', {
6969
'dockerfile_python_version': '3.4',
7070
}),
7171
('runtime_config:\n python_version: 3.5', {
7272
'dockerfile_python_version': '3.5',
7373
}),
74+
('runtime_config:\n python_version: 3.6', {
75+
'dockerfile_python_version': '3.6',
76+
}),
7477
# entrypoint present
7578
('entrypoint: my entrypoint', {
7679
'entrypoint': 'exec my entrypoint',

scripts/testdata/hello_world_golden/Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
FROM gcr.io/google-appengine/python
2-
LABEL python_version=python3.5
3-
RUN virtualenv --no-download /env -p python3.5
2+
LABEL python_version=python3.6
3+
RUN virtualenv --no-download /env -p python3.6
44

55
# Set virtualenv environment variables. This is equivalent to running
66
# source /env/bin/activate

0 commit comments

Comments
 (0)