From 775480c2d7164bb492b0c323911e6ae525173363 Mon Sep 17 00:00:00 2001 From: Thulio Ferraz Assis <3149049+f0rmiga@users.noreply.github.com> Date: Tue, 29 Nov 2022 09:23:39 -0800 Subject: [PATCH 1/2] fix: missing RunEnvironmentInfo Signed-off-by: Thulio Ferraz Assis <3149049+f0rmiga@users.noreply.github.com> --- python/config_settings/transition.bzl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/python/config_settings/transition.bzl b/python/config_settings/transition.bzl index 2fd3384543..0fb2fc36cb 100644 --- a/python/config_settings/transition.bzl +++ b/python/config_settings/transition.bzl @@ -58,10 +58,10 @@ def _transition_py_impl(ctx): dependency_attributes = ["target"], ), target[OutputGroupInfo], - # testing.TestEnvironment is deprecated in favour of RunEnvironmentInfo but + # TODO(f0rmiga): testing.TestEnvironment is deprecated in favour of RunEnvironmentInfo but # RunEnvironmentInfo is not exposed in Bazel < 5.3. # https://github.com/bazelbuild/bazel/commit/dbdfa07e92f99497be9c14265611ad2920161483 - (RunEnvironmentInfo if hasattr(native, "RunEnvironmentInfo") else testing.TestEnvironment)(environment = env), + testing.TestEnvironment(environment = env), ] return providers From 2204f1c563eba88bf966e6bce1a14ca57d3c06b5 Mon Sep 17 00:00:00 2001 From: Thulio Ferraz Assis <3149049+f0rmiga@users.noreply.github.com> Date: Tue, 29 Nov 2022 09:28:14 -0800 Subject: [PATCH 2/2] fix: add reference to github issue Signed-off-by: Thulio Ferraz Assis <3149049+f0rmiga@users.noreply.github.com> --- python/config_settings/transition.bzl | 1 + 1 file changed, 1 insertion(+) diff --git a/python/config_settings/transition.bzl b/python/config_settings/transition.bzl index 0fb2fc36cb..e87e2c9c22 100644 --- a/python/config_settings/transition.bzl +++ b/python/config_settings/transition.bzl @@ -60,6 +60,7 @@ def _transition_py_impl(ctx): target[OutputGroupInfo], # TODO(f0rmiga): testing.TestEnvironment is deprecated in favour of RunEnvironmentInfo but # RunEnvironmentInfo is not exposed in Bazel < 5.3. + # https://github.com/bazelbuild/rules_python/issues/901 # https://github.com/bazelbuild/bazel/commit/dbdfa07e92f99497be9c14265611ad2920161483 testing.TestEnvironment(environment = env), ]