-
-
Notifications
You must be signed in to change notification settings - Fork 740
Comparing changes
Open a pull request
base repository: bazel-contrib/rules_go
base: v0.58.3
head repository: bazel-contrib/rules_go
compare: v0.59.0
- 7 commits
- 39 files changed
- 5 contributors
Commits on Nov 3, 2025
-
Reland "go_sdk: store SDK filenames and hashes in lockfile facts" (#4493
) **What type of PR is this?** Feature **What does this PR do? Why is it needed?** This moves the download of the "all versions" JSON, which can't hit the repository cache, from each individual `go_download_sdk` into the module extension. If the current version of Bazel supports facts, this information will also be persisted in the lockfile, allowing for truly airgapped builds assuming an up-to-date download (formerly repository) cache. This is a reland of #4393 with the following improvements: * Adapted to the more limited facts API that actually got merged. * Prefetching of SDK hashes is now performed on a best-effort basis so that otherwise airgapped builds that provide SDK hashes do not result in failures. See bazelbuild/bazel#26198 for the PR that added facts support to Bazel. **Which issues(s) does this PR fix?** Fixes #3945 **Other notes for review** You can verify that this works by running `bazel mod show_repo @go_default_sdk` in the BCR test repo.
Configuration menu - View commit details
-
Copy full SHA for 30a6f8d - Browse repository at this point
Copy the full SHA 30a6f8dView commit details
Commits on Nov 4, 2025
-
correct macOS Tahoe 26 build via apple_support (#4500)
**What type of PR is this?** Bug fix **What does this PR do? Why is it needed?** All of rules_go tests were failing on macOS Tahoe 26 due to `missing LC_UUID load command` in the clang binary built and in other tools. Many tools from Go to bazel itself have had to drop various workarounds for these kinds of linker problems in the run-up to macOS Tahoe (see bazelbuild/apple_support@44c43c715a and bazelbuild/bazel#27014) To fix this, we bump the version of build_bazel_apple_support (a.k.a. apple_support in Bazel Central Registry) to 1.24.3 in WORKSPACE. We also have to move the build_bazel_apple_support dependency above the llvm_toolchain call in order to make sure that version is actually used. It's possible we should also upgrade the llvm_toolchain to something more modern to handle some of our deps problems. The current llvm used by rules_go is 8.0.0 and is from 2019. The latest llvm version that toolchains_llvm supports in its latest release 1.5.0 is llvm 21.1.0. **Which issues(s) does this PR fix?** Fixes #4499
Configuration menu - View commit details
-
Copy full SHA for b764503 - Browse repository at this point
Copy the full SHA b764503View commit details -
remove .vscode and gitignore it (#4498)
**What type of PR is this?** Other **What does this PR do? Why is it needed?** The .vscode directory isn't meant to be checked in like this, and causes churn that vscode users have to remove before sending PRs. We remove it, add it to .gitignore so future folks don't accidentally check it in. Folks can check out the more general Editor setup wiki page for instructions. **Which issues(s) does this PR fix?** Fixes #4497.
Configuration menu - View commit details
-
Copy full SHA for cdf4651 - Browse repository at this point
Copy the full SHA cdf4651View commit details -
Fix BCR test module for Bazel 9 (#4503)
**What type of PR is this?** Bug fix **What does this PR do? Why is it needed?** Also run all tests against the latest release candidate for each major release to catch issues early. **Which issues(s) does this PR fix?** Work towards bazelbuild/bazel-central-registry#6402 **Other notes for review**
Configuration menu - View commit details
-
Copy full SHA for dfed61b - Browse repository at this point
Copy the full SHA dfed61bView commit details -
docs: copy editor setup instructions from wiki to docs/editors.md (#4504
) **What type of PR is this?** > Documentation **What does this PR do? Why is it needed?** And link from README.rst. GitHub wikis seem to be downranked pretty hard by Google, so these instructions haven't been very visible. Linking from the README should help. **Which issues(s) does this PR fix?** n/a **Other notes for review** For some reason, the vim instructions were in docs/go/editors/vim.md instead of in the wiki. I've squashed them into a new section here.
Configuration menu - View commit details
-
Copy full SHA for 0b46a62 - Browse repository at this point
Copy the full SHA 0b46a62View commit details
Commits on Nov 7, 2025
-
Add
riscv64intoBAZEL_GOARCH_CONSTRAINTS(#4507)<!-- Thanks for sending a PR! Before submitting: 1. If this is your first PR, please read CONTRIBUTING.md and sign the CLA first. We cannot review code without a signed CLA. 2. Please file an issue *first*. All features and most bug fixes should have an associated issue with a design discussed and decided upon. Small bug fixes and documentation improvements don't need issues. 3. New features and bug fixes must have tests. Documentation may need to be updated. If you're unsure what to update, send the PR, and we'll discuss in review. 4. Note that PRs updating dependencies and new Go versions are not accepted. Please file an issue instead. --> **What type of PR is this?** Bug fix **What does this PR do? Why is it needed?** Fix some Bazel matching issues on riscv64 **Which issues(s) does this PR fix?** Fixes #4053 **Other notes for review** The riscv64 architecture has been widely developed and adopted recently, and optimizing support for riscv64 is very meaningful as it can provide better riscv64 support for downstream users. For example, when I was using `bazeldnf`, due to some limitations in the current repository, I couldn't use `bazeldnf` directly. The specific reason is this: https://github.com/rmohr/bazeldnf/blob/main/bazeldnf/platforms.bzl. This depends on the current repository's `BAZEL_GOARCH_CONSTRAINTS`, which currently lacks riscv64 support, so the riscv64 version of bazeldnf cannot be used directly. If this PR is merged and released, downstream users will be able to get good riscv64 support. A PR quite similar to this one is #3336. I think the situation with riscv64 is quite similar to that case. The Go upstream also provides good support for riscv64. **Other Info** Co-authored by: nijincheng@iscas.ac.cn;
Configuration menu - View commit details
-
Copy full SHA for 3fe89b8 - Browse repository at this point
Copy the full SHA 3fe89b8View commit details -
Add missing load statements (#4508)
This is required for compatibility with bazel @ HEAD. Done with: `buildifier --lint=fix -r .`
Configuration menu - View commit details
-
Copy full SHA for b3e12d7 - Browse repository at this point
Copy the full SHA b3e12d7View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v0.58.3...v0.59.0