Skip to content

Commit eea09fa

Browse files
author
Dean Troyer
committed
TODO cleanup: OSC_Config
os-client-config is now at 1.22.0 in global-requirements, we can remove this pw_func setting block as the pw_func arg to __init__() was added in 1.21.0. Change-Id: I5bbc3e3aae4f3e4c4333c73bba19bda65e0d8488
1 parent 1e3dc48 commit eea09fa

1 file changed

Lines changed: 0 additions & 34 deletions

File tree

openstackclient/common/client_config.py

Lines changed: 0 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -26,40 +26,6 @@
2626
# before auth plugins are loaded
2727
class OSC_Config(client_config.OSC_Config):
2828

29-
# TODO(dtroyer): Once os-client-config with pw_func argument is in
30-
# global-requirements we can remove __init()__
31-
def __init__(
32-
self,
33-
config_files=None,
34-
vendor_files=None,
35-
override_defaults=None,
36-
force_ipv4=None,
37-
envvar_prefix=None,
38-
secure_files=None,
39-
pw_func=None,
40-
):
41-
ret = super(OSC_Config, self).__init__(
42-
config_files=config_files,
43-
vendor_files=vendor_files,
44-
override_defaults=override_defaults,
45-
force_ipv4=force_ipv4,
46-
envvar_prefix=envvar_prefix,
47-
secure_files=secure_files,
48-
)
49-
50-
# NOTE(dtroyer): This will be pushed down into os-client-config
51-
# The default is there is no callback, the calling
52-
# application must specify what to use, typically
53-
# it will be osc_lib.shell.prompt_for_password()
54-
if '_pw_callback' not in vars(self):
55-
# Set the default if it doesn't already exist
56-
self._pw_callback = None
57-
if pw_func is not None:
58-
# Set the passed in value
59-
self._pw_callback = pw_func
60-
61-
return ret
62-
6329
# TODO(dtroyer): Remove _auth_default_domain when the v3otp fix is
6430
# backported to osc-lib, should be in release 1.3.0
6531
def _auth_default_domain(self, config):

0 commit comments

Comments
 (0)