Mask passwords in debug logs for auth_config_hook

Matt Riedemann · Matt Riedemann · commit cd1a412408f0 · 2016-10-05T21:11:16.000-04:00
The auth config hook can have credentials in it so
we have to mask the config before logging it. To
avoid doing the work of masking the password if we
aren't going to log it, there is a conditional put
around the actual debug statement.

Change-Id: I8e626672ec94fc837610216bccb4354dbdedca17
Closes-Bug: #1630822
diff --git a/openstackclient/common/client_config.py b/openstackclient/common/client_config.py
@@ -17,6 +17,8 @@
 
 from os_client_config import config
 from os_client_config import exceptions as occ_exceptions
+from oslo_utils import strutils
+import six
 
 
 LOG = logging.getLogger(__name__)
@@ -180,7 +182,9 @@ def auth_config_hook(self, config):
         config = self._auth_v2_ignore_v3(config)
         config = self._auth_default_domain(config)
 
-        LOG.debug("auth_config_hook(): %s" % config)
+        if LOG.isEnabledFor(logging.DEBUG):
+            LOG.debug("auth_config_hook(): %s",
+                      strutils.mask_password(six.text_type(config)))
         return config
 
     def load_auth_plugin(self, config):
