Make 'object save' fast again

Jordan Pittier · stevemar · commit 1cdc1319d6cb · 2017-01-09T16:19:29.000Z
'openstack object save' is critically slow to download big objects. While we 'stream' (chunked download) the data, the default chunks_size is 1 byte [1], which is terribly inefficient. [1] : http://docs.python-requests.org/en/master/api/#requests.Response.iter_content Closes-Bug: 1654645 Change-Id: I2223e5897346acd2f2c1fae638d1193cff833c19
diff --git a/openstackclient/api/object_store_v1.py b/openstackclient/api/object_store_v1.py
@@ -380,7 +380,7 @@ def object_save(
                 if len(os.path.dirname(file)) > 0:
                     os.makedirs(os.path.dirname(file))
             with open(file, 'wb') as f:
-                for chunk in response.iter_content():
+                for chunk in response.iter_content(64 * 1024):
                     f.write(chunk)
 
     def object_set(
diff --git a/releasenotes/notes/speedup-object-save-6bd59e678a31c3e8.yaml b/releasenotes/notes/speedup-object-save-6bd59e678a31c3e8.yaml
@@ -0,0 +1,5 @@
+---
+fixes:
+  - |
+     Makes ``openstack object save`` much faster when saving an object to disk.
+     [Bug `1654645 <https://bugs.launchpad.net/bugs/1654645>`_]

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +fixes:
 +  - |
 +     Makes ``openstack object save`` much faster when saving an object to disk.
 +     [Bug `1654645 <https://bugs.launchpad.net/bugs/1654645>`_]