Windows test fixes python#7, also fix missing docs ref

barneygale · barneygale · commit 7584b6538e89 · 2024-10-30T00:14:51.000Z
diff --git a/Doc/library/urllib.request.rst b/Doc/library/urllib.request.rst
@@ -169,10 +169,11 @@ The :mod:`urllib.request` module defines the following functions:
    Convert the percent-encoded *url* to a local pathname.
 
    .. versionchanged:: 3.14
-      Supports :rfc:`8089`-compliant file URLs. Raises :exc:`URLError` if a
-      scheme other than ``file:`` is used. If the URL uses a non-local
-      authority, then on Windows a UNC path is returned, and on other
-      platforms a :exc:`URLError` exception is raised.
+      Supports :rfc:`8089`-compliant file URLs. Raises
+      :exc:`~urllib.error.URLError` if a scheme other than ``file:`` is used.
+      If the URL uses a non-local authority, then on Windows a UNC path is
+      returned, and on other platforms a :exc:`~urllib.error.URLError`
+      exception is raised.
 
 
 .. function:: getproxies()
diff --git a/Lib/test/test_urllib2.py b/Lib/test/test_urllib2.py
@@ -824,7 +824,7 @@ def test_file(self):
             "file://localhost%s" % urlpath,
             "file://%s" % urlpath,
             ]
-        if os.name == 'nt':
+        if os.name != 'nt':
             urls.append("file://%s%s" % (socket.gethostbyname('localhost'), urlpath))
             try:
                 localaddr = socket.gethostbyname(socket.gethostname())

Original file line number	Diff line number	Diff line change
`@@ -824,7 +824,7 @@ def test_file(self):`
`824`	`824`	`"file://localhost%s" % urlpath,`
`825`	`825`	`"file://%s" % urlpath,`
`826`	`826`	`]`
`827`		`- if os.name == 'nt':`
	`827`	`+ if os.name != 'nt':`
`828`	`828`	`urls.append("file://%s%s" % (socket.gethostbyname('localhost'), urlpath))`
`829`	`829`	`try:`
`830`	`830`	`localaddr = socket.gethostbyname(socket.gethostname())`