fix: handle yt-dlp GitHub API rate limit gracefully

barkleesanders · claude · barkleesanders · commit 08a3d804eb64 · 2026-03-08T13:57:58.000-07:00
When yt-dlp -U hits GitHub's API rate limit (HTTP 403), skip the
step gracefully instead of reporting a hard failure. The rate limit
is transient and not actionable by the user during the run.

Tested: full topgrade run completes with 0 failures.

Co-Authored-By: Claude Opus 4.6 &lt;noreply@anthropic.com&gt;
diff --git a/src/steps/generic.rs b/src/steps/generic.rs
@@ -2563,8 +2563,17 @@ pub fn run_ytdlp(ctx: &ExecutionContext) -> Result<()> {
         return Ok(());
     }
 
-    // Check if it failed due to a permission error (e.g., installed to /usr/local/bin)
     let combined_lower = combined.to_lowercase();
+
+    // If it hit a GitHub API rate limit, skip gracefully instead of failing
+    if combined_lower.contains("rate limit") {
+        std::io::stderr().lock().write_all(&output.stderr).unwrap();
+        return Err(
+            SkipStep("yt-dlp update skipped: GitHub API rate limit exceeded, try again later".to_string()).into(),
+        );
+    }
+
+    // Check if it failed due to a permission error (e.g., installed to /usr/local/bin)
     if combined_lower.contains("unable to write") || combined_lower.contains("permission denied") {
         // Retry with sudo
         let sudo = ctx.require_sudo()?;
