CLOUDSTACK-6289: fixed storage migration failing in case of hyper-v if there are multiple disks attached to VM

anshulgangwar · devdeep · commit 1dfe4c19b5b1 · 2014-04-08T14:39:13.000+05:30
diff --git a/plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/WmiCallsV2.cs b/plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/WmiCallsV2.cs
@@ -1099,8 +1099,7 @@ public void MigrateVolume(string vmName, string volume, string destination)
             string[] rasds = null;
             if (sasd != null)
             {
-                rasds = new string[sasd.Length];
-                uint index = 0;
+                rasds = new string[1];
                 foreach (StorageAllocationSettingData item in sasd)
                 {
                     string vhdFileName = Path.GetFileNameWithoutExtension(item.HostResource[0]);
@@ -1109,9 +1108,9 @@ public void MigrateVolume(string vmName, string volume, string destination)
                         string newVhdPath = Path.Combine(destination, Path.GetFileName(item.HostResource[0]));
                         item.LateBoundObject["HostResource"] = new string[] { newVhdPath };
                         item.LateBoundObject["PoolId"] = "";
+                        rasds[0] = item.LateBoundObject.GetText(System.Management.TextFormat.CimDtd20);
+                        break;
                     }
-
-                    rasds[index++] = item.LateBoundObject.GetText(System.Management.TextFormat.CimDtd20);
                 }
             }
 

Original file line number	Diff line number	Diff line change
`@@ -1099,8 +1099,7 @@ public void MigrateVolume(string vmName, string volume, string destination)`
`1099`	`1099`	`string[] rasds = null;`
`1100`	`1100`	`if (sasd != null)`
`1101`	`1101`	`{`
`1102`		`- rasds = new string[sasd.Length];`
`1103`		`- uint index = 0;`
	`1102`	`+ rasds = new string[1];`
`1104`	`1103`	`foreach (StorageAllocationSettingData item in sasd)`
`1105`	`1104`	`{`
`1106`	`1105`	`string vhdFileName = Path.GetFileNameWithoutExtension(item.HostResource[0]);`
`@@ -1109,9 +1108,9 @@ public void MigrateVolume(string vmName, string volume, string destination)`
`1109`	`1108`	`string newVhdPath = Path.Combine(destination, Path.GetFileName(item.HostResource[0]));`
`1110`	`1109`	`item.LateBoundObject["HostResource"] = new string[] { newVhdPath };`
`1111`	`1110`	`item.LateBoundObject["PoolId"] = "";`
	`1111`	`+ rasds[0] = item.LateBoundObject.GetText(System.Management.TextFormat.CimDtd20);`
	`1112`	`+ break;`
`1112`	`1113`	`}`
`1113`		`-`
`1114`		`- rasds[index++] = item.LateBoundObject.GetText(System.Management.TextFormat.CimDtd20);`
`1115`	`1114`	`}`
`1116`	`1115`	`}`
`1117`	`1116`