Repository navigation
Simplify buildNamespaceReexport #9109
Description
This code is meant to prevent __esModule from being overwritten:
It’s helpful in loose mode, but for non-loose mode the key === "__esModule" is redundant, since the __esModule property is then added as follows:
Object.defineProperty(exports, '__esModule', {
value: true
});Note that enumerable: false is implied here, and so __esModule won’t show up in Object.keys(exports).
Your mission, should you choose to accept it, is to remove this redundant check from the non-loose mode code path!
Activity
babel-bot commentedon Dec 1, 2018
Hey @mathiasbynens! We really appreciate you taking the time to report an issue. The collaborators
on this project attempt to help as many people as possible, but we're a limited number of volunteers,
so it's possible this won't be addressed swiftly.
If you need any help, or just have general Babel or JavaScript questions, we have a vibrant Slack
community that typically always has someone willing to help. You can sign-up here
for an invite.
loganfsmyth commentedon Dec 1, 2018
I don't think we can do that safely because it's not a question of if the current file is running in loose mode, but rather if the module namespace that is being re-exported is in loose mode.
mathiasbynens commentedon Dec 1, 2018
In that case we should close this issue :)