fix: usePrivateName usage

JLHwung · nicolo-ribaudo · commit d50c18dbc282 · 2022-02-02T00:22:00.000+01:00
diff --git a/packages/babel-parser/src/parser/lval.js b/packages/babel-parser/src/parser/lval.js
@@ -148,7 +148,10 @@ export default class LValParser extends NodeUtils {
       case "ObjectProperty": {
         const { key, value } = node;
         if (this.isPrivateName(key)) {
-          this.classScope.usePrivateName(this.getPrivateNameSV(key), key.start);
+          this.classScope.usePrivateName(
+            this.getPrivateNameSV(key),
+            key.loc.start,
+          );
         }
         this.toAssignable(value, isLHS);
         break;
@@ -436,7 +439,7 @@ export default class LValParser extends NodeUtils {
       return this.parseBindingRestProperty(prop);
     } else if (type === tt.privateName) {
       this.expectPlugin("destructuringPrivate", startLoc);
-      this.classScope.usePrivateName(this.state.value, startPos);
+      this.classScope.usePrivateName(this.state.value, startLoc);
       prop.key = this.parsePrivateName();
     } else {
       this.parsePropertyName(prop);
diff --git a/packages/babel-parser/src/plugins/estree.js b/packages/babel-parser/src/plugins/estree.js
@@ -332,7 +332,10 @@ export default (superClass: Class<Parser>): Class<Parser> =>
       if (node != null && this.isObjectProperty(node)) {
         const { key, value } = node;
         if (this.isPrivateName(key)) {
-          this.classScope.usePrivateName(this.getPrivateNameSV(key), key.start);
+          this.classScope.usePrivateName(
+            this.getPrivateNameSV(key),
+            key.loc.start,
+          );
         }
         this.toAssignable(value, isLHS);
         return node;
diff --git a/packages/babel-parser/test/fixtures/experimental/destructuring-private/invalid-undefined-private-name/output.json b/packages/babel-parser/test/fixtures/experimental/destructuring-private/invalid-undefined-private-name/output.json
@@ -2,11 +2,11 @@
   "type": "File",
   "start":0,"end":140,"loc":{"start":{"line":1,"column":0},"end":{"line":9,"column":1}},
   "errors": [
-    "SyntaxError: Private name #a is not defined. (undefined:undefined)",
-    "SyntaxError: Private name #b is not defined. (undefined:undefined)",
-    "SyntaxError: Private name #c is not defined. (undefined:undefined)",
-    "SyntaxError: Private name #d is not defined. (undefined:undefined)",
-    "SyntaxError: Private name #e is not defined. (undefined:undefined)"
+    "SyntaxError: Private name #a is not defined. (3:6)",
+    "SyntaxError: Private name #b is not defined. (4:12)",
+    "SyntaxError: Private name #c is not defined. (5:9)",
+    "SyntaxError: Private name #d is not defined. (6:10)",
+    "SyntaxError: Private name #e is not defined. (7:7)"
   ],
   "program": {
     "type": "Program",
