Wait the correct number of ticks on nested await (#13961)

nicolo-ribaudo · web-flow · commit d16f8111ea70 · 2021-11-14T02:02:35.000+01:00
diff --git a/packages/babel-helper-remap-async-to-generator/src/index.js b/packages/babel-helper-remap-async-to-generator/src/index.js
@@ -19,11 +19,6 @@ const awaitVisitor = {
   AwaitExpression(path, { wrapAwait }) {
     const argument = path.get("argument");
 
-    if (path.parentPath.isYieldExpression()) {
-      path.replaceWith(argument.node);
-      return;
-    }
-
     path.replaceWith(
       yieldExpression(
         wrapAwait
diff --git a/packages/babel-plugin-transform-async-to-generator/test/fixtures/async-to-generator/double-await/exec.js b/packages/babel-plugin-transform-async-to-generator/test/fixtures/async-to-generator/double-await/exec.js
@@ -0,0 +1,20 @@
+const log = [];
+
+const p1 = (async function () {
+  log.push(1);
+  await await null;
+  log.push(2);
+})();
+
+const p2 = (async function () {
+  log.push(3);
+  await null;
+  log.push(4);
+})();
+
+log.push(5);
+const p3 = Promise.resolve().then(() => log.push(6)).then(() => log.push(7));
+
+return Promise.all([p1, p2, p3]).then(() => {
+  expect(log).toEqual([1, 3, 5, 4, 6, 2, 7]);
+});
diff --git a/packages/babel-plugin-transform-async-to-generator/test/fixtures/async-to-generator/double-await/input.js b/packages/babel-plugin-transform-async-to-generator/test/fixtures/async-to-generator/double-await/input.js
@@ -0,0 +1,3 @@
+async function fn() {
+  await await 1;
+}
diff --git a/packages/babel-plugin-transform-async-to-generator/test/fixtures/async-to-generator/double-await/options.json b/packages/babel-plugin-transform-async-to-generator/test/fixtures/async-to-generator/double-await/options.json
@@ -0,0 +1,5 @@
+{
+  "parserOpts": {
+    "allowReturnOutsideFunction": true
+  }
+}
diff --git a/packages/babel-plugin-transform-async-to-generator/test/fixtures/async-to-generator/double-await/output.js b/packages/babel-plugin-transform-async-to-generator/test/fixtures/async-to-generator/double-await/output.js
@@ -0,0 +1,10 @@
+function fn() {
+  return _fn.apply(this, arguments);
+}
+
+function _fn() {
+  _fn = babelHelpers.asyncToGenerator(function* () {
+    yield yield 1;
+  });
+  return _fn.apply(this, arguments);
+}

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+async function fn() {`
	`2`	`+ await await 1;`
	`3`	`+}`
-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +{
 +  "parserOpts": {
 +    "allowReturnOutsideFunction": true
 +  }
 +}