Don't mutate @babel/register options (#14107)

nicolo-ribaudo · web-flow · commit d158a48945a0 · 2022-01-06T18:37:45.000+01:00
diff --git a/packages/babel-register/src/node.js b/packages/babel-register/src/node.js
@@ -5,7 +5,10 @@
 const hook = require("./hook");
 const { LocalClient } = require("./worker-client");
 
-const register = hook.register.bind(null, new LocalClient());
+const client = new LocalClient();
+function register(opts = {}) {
+  return hook.register(client, { ...opts });
+}
 
 module.exports = Object.assign(register, {
   revert: hook.revert,
diff --git a/packages/babel-register/test/index.js b/packages/babel-register/test/index.js
@@ -118,7 +118,33 @@ describe("@babel/register", function () {
         });
       }
 
-      buildTests(require.resolve(".."));
+      const { setupRegister } = buildTests(require.resolve(".."));
+
+      it("does not mutate options", () => {
+        const proxyHandler = {
+          defineProperty: jest.fn(Reflect.defineProperty),
+          deleteProperty: jest.fn(Reflect.deleteProperty),
+          set: jest.fn(Reflect.set),
+        };
+
+        setupRegister(
+          new Proxy(
+            {
+              babelrc: true,
+              sourceMaps: false,
+              cwd: path.dirname(testFileMjs),
+              extensions: [".js"],
+            },
+            proxyHandler,
+          ),
+        );
+
+        currentHook(testFileContent, testFile);
+
+        expect(proxyHandler.defineProperty).not.toHaveBeenCalled();
+        expect(proxyHandler.deleteProperty).not.toHaveBeenCalled();
+        expect(proxyHandler.set).not.toHaveBeenCalled();
+      });
     });
   }
 
@@ -344,6 +370,32 @@ describe("@babel/register", function () {
       expect(convertSourceMap).toMatch("/* transformed */");
     });
 
+    test("does not mutate options", () => {
+      const proxyHandler = {
+        defineProperty: jest.fn(Reflect.defineProperty),
+        deleteProperty: jest.fn(Reflect.deleteProperty),
+        set: jest.fn(Reflect.set),
+      };
+
+      setupRegister(
+        new Proxy(
+          {
+            babelrc: true,
+            sourceMaps: false,
+            cwd: path.dirname(testFileMjs),
+            extensions: [".js"],
+          },
+          proxyHandler,
+        ),
+      );
+
+      currentHook(testFileContent, testFile);
+
+      expect(proxyHandler.defineProperty).not.toHaveBeenCalled();
+      expect(proxyHandler.deleteProperty).not.toHaveBeenCalled();
+      expect(proxyHandler.set).not.toHaveBeenCalled();
+    });
+
     return { setupRegister, revertRegister };
   }
 });
