tests: fix coverage for babel-cli (#14965)

liuxingbaoyu · nicolo-ribaudo · web-flow · commit bf3b20ae1820 · 2022-09-27T14:52:45.000+02:00
Co-authored-by: Nicolò Ribaudo &lt;nicolo.ribaudo@gmail.com&gt;
diff --git a/packages/babel-cli/package.json b/packages/babel-cli/package.json
@@ -44,7 +44,8 @@
     "@babel/helper-fixtures": "workspace:^",
     "@types/fs-readdir-recursive": "^1.1.0",
     "@types/glob": "^7.2.0",
-    "rimraf": "^3.0.0"
+    "rimraf": "^3.0.0",
+    "semver": "^6.3.0"
   },
   "bin": {
     "babel": "./bin/babel.js",
diff --git a/packages/babel-cli/test/exit-loader.cjs b/packages/babel-cli/test/exit-loader.cjs
@@ -0,0 +1,5 @@
+// We need to gracefully exit rather than just terminating spawn tests with SIGINT
+// to let c8 correctly report the collected coverage info.
+// eslint-disable-next-line no-process-exit
+process.on("message", () => process.exit(0));
+process.channel.unref();
diff --git a/packages/babel-cli/test/index.js b/packages/babel-cli/test/index.js
@@ -1,6 +1,7 @@
 import readdir from "fs-readdir-recursive";
 import * as helper from "@babel/helper-fixtures";
 import rimraf from "rimraf";
+import semver from "semver";
 import child from "child_process";
 import path from "path";
 import fs from "fs";
@@ -150,13 +151,17 @@ const assertTest = function (stdout, stderr, opts, cwd) {
   }
 };
 
+const nodeGte8 = semver.gte(process.version, "8.0.0");
+
 const buildTest = function (binName, testName, opts) {
   const binLoc = path.join(dirname, "../lib", binName);
 
   return function (callback) {
     saveInFiles(opts.inFiles);
 
-    let args = [binLoc];
+    let args = nodeGte8
+      ? ["--require", path.join(dirname, "./exit-loader.cjs"), binLoc]
+      : [binLoc];
 
     if (binName !== "babel-external-helpers" && !opts.noDefaultPlugins) {
       args.push("--presets", presetLocs, "--plugins", pluginLocs);
@@ -165,7 +170,11 @@ const buildTest = function (binName, testName, opts) {
     args = args.concat(opts.args);
     const env = { ...process.env, ...opts.env };
 
-    const spawn = child.spawn(process.execPath, args, { env, cwd: tmpLoc });
+    const spawn = child.spawn(process.execPath, args, {
+      env,
+      cwd: tmpLoc,
+      stdio: [null, null, null, "ipc"],
+    });
 
     let stderr = "";
     let stdout = "";
@@ -211,7 +220,11 @@ const buildTest = function (binName, testName, opts) {
       spawn.stderr.pipe(executor.stdin);
 
       executor.on("close", function () {
-        setTimeout(() => spawn.kill("SIGINT"), 250);
+        if (nodeGte8) {
+          spawn.send("exit");
+        } else {
+          spawn.kill("SIGKILL");
+        }
       });
 
       captureOutput(executor);
diff --git a/yarn.lock b/yarn.lock
@@ -214,6 +214,7 @@ __metadata:
     glob: ^7.2.0
     make-dir: "condition:BABEL_8_BREAKING ? : ^2.1.0"
     rimraf: ^3.0.0
+    semver: ^6.3.0
     slash: "condition:BABEL_8_BREAKING ? ^3.0.0 : ^2.0.0"
   peerDependencies:
     "@babel/core": ^7.0.0-0
