Misc: Cleanup Babel 8 tasks (#17429)

JLHwung · web-flow · commit 98d18aa4f66c · 2025-08-07T08:43:35.000-04:00
diff --git a/packages/babel-cli/src/babel/util.ts b/packages/babel-cli/src/babel/util.ts
@@ -98,6 +98,9 @@ export function hasDataSourcemap(code: string): boolean {
 
 const CALLER = {
   name: "@babel/cli",
+  supportsStaticESM: false,
+  supportsDynamicImport: false,
+  supportsExportNamespaceFrom: false,
 };
 
 export function transformRepl(filename: string, code: string, opts: any) {
diff --git a/packages/babel-cli/test/fixtures/babel/env - SHOW_CONFIG_FOR with multiple files-windows/stdout.txt b/packages/babel-cli/test/fixtures/babel/env - SHOW_CONFIG_FOR with multiple files-windows/stdout.txt
@@ -25,7 +25,10 @@ programmatic options from @babel/cli
   ],
   "sourceFileName": "src/foo.js",
   "caller": {
-    "name": "@babel/cli"
+    "name": "@babel/cli",
+    "supportsStaticESM": false,
+    "supportsDynamicImport": false,
+    "supportsExportNamespaceFrom": false
   },
   "filename": "src//foo.js"
 }
diff --git a/packages/babel-cli/test/fixtures/babel/env - SHOW_CONFIG_FOR with multiple files/stdout.txt b/packages/babel-cli/test/fixtures/babel/env - SHOW_CONFIG_FOR with multiple files/stdout.txt
@@ -25,7 +25,10 @@ programmatic options from @babel/cli
   ],
   "sourceFileName": "src/foo.js",
   "caller": {
-    "name": "@babel/cli"
+    "name": "@babel/cli",
+    "supportsStaticESM": false,
+    "supportsDynamicImport": false,
+    "supportsExportNamespaceFrom": false
   },
   "filename": "src/foo.js"
 }
diff --git a/packages/babel-cli/test/fixtures/babel/env - SHOW_CONFIG_FOR-windows/stdout.txt b/packages/babel-cli/test/fixtures/babel/env - SHOW_CONFIG_FOR-windows/stdout.txt
@@ -25,7 +25,10 @@ programmatic options from @babel/cli
   ],
   "sourceFileName": "../src/foo.js",
   "caller": {
-    "name": "@babel/cli"
+    "name": "@babel/cli",
+    "supportsStaticESM": false,
+    "supportsDynamicImport": false,
+    "supportsExportNamespaceFrom": false
   },
   "filename": "src//foo.js"
 }
diff --git a/packages/babel-cli/test/fixtures/babel/env - SHOW_CONFIG_FOR/stdout.txt b/packages/babel-cli/test/fixtures/babel/env - SHOW_CONFIG_FOR/stdout.txt
@@ -120,7 +120,10 @@ programmatic options from @babel/cli
   "configFile": "./my-config.js",
   "sourceFileName": "./src/index.js",
   "caller": {
-    "name": "@babel/cli"
+    "name": "@babel/cli",
+    "supportsStaticESM": false,
+    "supportsDynamicImport": false,
+    "supportsExportNamespaceFrom": false
   },
   "filename": "./src/index.js"
 }
diff --git a/packages/babel-core/src/config/validation/options.ts b/packages/babel-core/src/config/validation/options.ts
@@ -203,6 +203,10 @@ export type CallerMetadata = {
   // If 'caller' is specified, require that the name is given for debugging
   // messages.
   name: string;
+  supportsStaticESM?: boolean;
+  supportsDynamicImport?: boolean;
+  supportsTopLevelAwait?: boolean;
+  supportsExportNamespaceFrom?: boolean;
 };
 export type EnvSet<T> = {
   [x: string]: T;
diff --git a/packages/babel-generator/src/generators/expressions.ts b/packages/babel-generator/src/generators/expressions.ts
@@ -97,12 +97,10 @@ export function NewExpression(
   if (!process.env.BABEL_8_BREAKING) {
     // @ts-ignore(Babel 7 vs Babel 8) Removed in Babel 8
     this.print(node.typeParameters); // Legacy TS AST
-  }
-
-  // @ts-ignore(Babel 7 vs Babel 8) Removed in Babel 8
-  if (node.optional) {
-    // TODO: This can never happen
-    this.token("?.");
+    // @ts-ignore(Babel 7 vs Babel 8) Removed in Babel 8
+    if (node.optional) {
+      this.token("?.");
+    }
   }
 
   if (
diff --git a/packages/babel-helper-module-transforms/src/normalize-and-load-metadata.ts b/packages/babel-helper-module-transforms/src/normalize-and-load-metadata.ts
@@ -278,7 +278,7 @@ function getModuleMetadata(
 
         // @ts-expect-error lazy is not listed in the type.
         // This is needed for compatibility with older version of the commonjs
-        // plusing.
+        // plugins.
         // TODO(Babel 8): Remove this
         get lazy() {
           return this.wrap === "lazy";
diff --git a/packages/babel-helper-transform-fixture-test-runner/src/index.ts b/packages/babel-helper-transform-fixture-test-runner/src/index.ts
@@ -77,6 +77,12 @@ function transformWithoutConfigFile(code: string, opts: InputOptions) {
     browserslistConfigFile: false,
     configFile: false,
     babelrc: false,
+    caller: {
+      name: "babel-helper-transform-fixture-test-runner/sync",
+      supportsStaticESM: false,
+      supportsDynamicImport: false,
+      supportsExportNamespaceFrom: false,
+    },
     ...opts,
   });
 }
@@ -85,6 +91,12 @@ function transformAsyncWithoutConfigFile(code: string, opts: InputOptions) {
     browserslistConfigFile: false,
     configFile: false,
     babelrc: false,
+    caller: {
+      name: "babel-helper-transform-fixture-test-runner/async",
+      supportsStaticESM: false,
+      supportsDynamicImport: false,
+      supportsExportNamespaceFrom: false,
+    },
     ...opts,
   });
 }
diff --git a/packages/babel-parser/src/plugins/estree.ts b/packages/babel-parser/src/plugins/estree.ts
@@ -503,10 +503,11 @@ export default (superClass: typeof Parser) =>
           .arguments[0] as N.Expression;
         (node as N.Node as N.EstreeImportExpression).options =
           (node.arguments[1] as N.Expression) ?? null;
-        // compatibility with previous ESTree AST
-        // TODO(Babel 8): Remove this
-        (node as N.Node as N.EstreeImportExpression).attributes =
-          (node.arguments[1] as N.Expression) ?? null;
+        if (!process.env.BABEL_8_BREAKING) {
+          // compatibility with previous ESTree AST
+          (node as N.Node as N.EstreeImportExpression).attributes =
+            (node.arguments[1] as N.Expression) ?? null;
+        }
         // arguments isn't optional in the type definition
         delete node.arguments;
         // callee isn't optional in the type definition
diff --git a/packages/babel-parser/test/fixtures/estree/dynamic-import/basic-babel-7/input.js b/packages/babel-parser/test/fixtures/estree/dynamic-import/basic-babel-7/input.js
@@ -0,0 +1 @@
+const a = import("a");
diff --git a/packages/babel-parser/test/fixtures/estree/dynamic-import/basic-babel-7/options.json b/packages/babel-parser/test/fixtures/estree/dynamic-import/basic-babel-7/options.json
@@ -0,0 +1,3 @@
+{
+  "BABEL_8_BREAKING": false
+}
diff --git a/packages/babel-parser/test/fixtures/estree/dynamic-import/basic-babel-7/output.json b/packages/babel-parser/test/fixtures/estree/dynamic-import/basic-babel-7/output.json
@@ -0,0 +1,40 @@
+{
+  "type": "File",
+  "start":0,"end":22,"loc":{"start":{"line":1,"column":0},"end":{"line":1,"column":22}},
+  "program": {
+    "type": "Program",
+    "start":0,"end":22,"loc":{"start":{"line":1,"column":0},"end":{"line":1,"column":22}},
+    "sourceType": "script",
+    "interpreter": null,
+    "body": [
+      {
+        "type": "VariableDeclaration",
+        "start":0,"end":22,"loc":{"start":{"line":1,"column":0},"end":{"line":1,"column":22}},
+        "declarations": [
+          {
+            "type": "VariableDeclarator",
+            "start":6,"end":21,"loc":{"start":{"line":1,"column":6},"end":{"line":1,"column":21}},
+            "id": {
+              "type": "Identifier",
+              "start":6,"end":7,"loc":{"start":{"line":1,"column":6},"end":{"line":1,"column":7},"identifierName":"a"},
+              "name": "a"
+            },
+            "init": {
+              "type": "ImportExpression",
+              "start":10,"end":21,"loc":{"start":{"line":1,"column":10},"end":{"line":1,"column":21}},
+              "source": {
+                "type": "Literal",
+                "start":17,"end":20,"loc":{"start":{"line":1,"column":17},"end":{"line":1,"column":20}},
+                "value": "a",
+                "raw": "\"a\""
+              },
+              "options": null,
+              "attributes": null
+            }
+          }
+        ],
+        "kind": "const"
+      }
+    ]
+  }
+}
diff --git a/packages/babel-parser/test/fixtures/estree/dynamic-import/basic/options.json b/packages/babel-parser/test/fixtures/estree/dynamic-import/basic/options.json
@@ -0,0 +1,3 @@
+{
+  "BABEL_8_BREAKING": true
+}
diff --git a/packages/babel-parser/test/fixtures/estree/dynamic-import/basic/output.json b/packages/babel-parser/test/fixtures/estree/dynamic-import/basic/output.json
@@ -28,8 +28,7 @@
                 "value": "a",
                 "raw": "\"a\""
               },
-              "options": null,
-              "attributes": null
+              "options": null
             }
           }
         ],
diff --git a/packages/babel-parser/test/fixtures/estree/dynamic-import/import-attributes-babel-7/input.js b/packages/babel-parser/test/fixtures/estree/dynamic-import/import-attributes-babel-7/input.js
@@ -0,0 +1 @@
+import("module", { with: { type: "json" } });
diff --git a/packages/babel-parser/test/fixtures/estree/dynamic-import/import-attributes-babel-7/options.json b/packages/babel-parser/test/fixtures/estree/dynamic-import/import-attributes-babel-7/options.json
@@ -0,0 +1,6 @@
+{
+  "plugins": [
+    "estree"
+  ],
+  "BABEL_8_BREAKING": false
+}
diff --git a/packages/babel-parser/test/fixtures/estree/dynamic-import/import-attributes-babel-7/output.json b/packages/babel-parser/test/fixtures/estree/dynamic-import/import-attributes-babel-7/output.json
@@ -0,0 +1,114 @@
+{
+  "type": "File",
+  "start":0,"end":45,"loc":{"start":{"line":1,"column":0},"end":{"line":1,"column":45}},
+  "program": {
+    "type": "Program",
+    "start":0,"end":45,"loc":{"start":{"line":1,"column":0},"end":{"line":1,"column":45}},
+    "sourceType": "script",
+    "interpreter": null,
+    "body": [
+      {
+        "type": "ExpressionStatement",
+        "start":0,"end":45,"loc":{"start":{"line":1,"column":0},"end":{"line":1,"column":45}},
+        "expression": {
+          "type": "ImportExpression",
+          "start":0,"end":44,"loc":{"start":{"line":1,"column":0},"end":{"line":1,"column":44}},
+          "source": {
+            "type": "Literal",
+            "start":7,"end":15,"loc":{"start":{"line":1,"column":7},"end":{"line":1,"column":15}},
+            "value": "module",
+            "raw": "\"module\""
+          },
+          "options": {
+            "type": "ObjectExpression",
+            "start":17,"end":43,"loc":{"start":{"line":1,"column":17},"end":{"line":1,"column":43}},
+            "properties": [
+              {
+                "type": "Property",
+                "start":19,"end":41,"loc":{"start":{"line":1,"column":19},"end":{"line":1,"column":41}},
+                "method": false,
+                "key": {
+                  "type": "Identifier",
+                  "start":19,"end":23,"loc":{"start":{"line":1,"column":19},"end":{"line":1,"column":23},"identifierName":"with"},
+                  "name": "with"
+                },
+                "computed": false,
+                "shorthand": false,
+                "value": {
+                  "type": "ObjectExpression",
+                  "start":25,"end":41,"loc":{"start":{"line":1,"column":25},"end":{"line":1,"column":41}},
+                  "properties": [
+                    {
+                      "type": "Property",
+                      "start":27,"end":39,"loc":{"start":{"line":1,"column":27},"end":{"line":1,"column":39}},
+                      "method": false,
+                      "key": {
+                        "type": "Identifier",
+                        "start":27,"end":31,"loc":{"start":{"line":1,"column":27},"end":{"line":1,"column":31},"identifierName":"type"},
+                        "name": "type"
+                      },
+                      "computed": false,
+                      "shorthand": false,
+                      "value": {
+                        "type": "Literal",
+                        "start":33,"end":39,"loc":{"start":{"line":1,"column":33},"end":{"line":1,"column":39}},
+                        "value": "json",
+                        "raw": "\"json\""
+                      },
+                      "kind": "init"
+                    }
+                  ]
+                },
+                "kind": "init"
+              }
+            ]
+          },
+          "attributes": {
+            "type": "ObjectExpression",
+            "start":17,"end":43,"loc":{"start":{"line":1,"column":17},"end":{"line":1,"column":43}},
+            "properties": [
+              {
+                "type": "Property",
+                "start":19,"end":41,"loc":{"start":{"line":1,"column":19},"end":{"line":1,"column":41}},
+                "method": false,
+                "key": {
+                  "type": "Identifier",
+                  "start":19,"end":23,"loc":{"start":{"line":1,"column":19},"end":{"line":1,"column":23},"identifierName":"with"},
+                  "name": "with"
+                },
+                "computed": false,
+                "shorthand": false,
+                "value": {
+                  "type": "ObjectExpression",
+                  "start":25,"end":41,"loc":{"start":{"line":1,"column":25},"end":{"line":1,"column":41}},
+                  "properties": [
+                    {
+                      "type": "Property",
+                      "start":27,"end":39,"loc":{"start":{"line":1,"column":27},"end":{"line":1,"column":39}},
+                      "method": false,
+                      "key": {
+                        "type": "Identifier",
+                        "start":27,"end":31,"loc":{"start":{"line":1,"column":27},"end":{"line":1,"column":31},"identifierName":"type"},
+                        "name": "type"
+                      },
+                      "computed": false,
+                      "shorthand": false,
+                      "value": {
+                        "type": "Literal",
+                        "start":33,"end":39,"loc":{"start":{"line":1,"column":33},"end":{"line":1,"column":39}},
+                        "value": "json",
+                        "raw": "\"json\""
+                      },
+                      "kind": "init"
+                    }
+                  ]
+                },
+                "kind": "init"
+              }
+            ]
+          }
+        }
+      }
+    ]
+  }
+}
diff --git a/packages/babel-parser/test/fixtures/estree/dynamic-import/import-attributes-null-babel-7/input.js b/packages/babel-parser/test/fixtures/estree/dynamic-import/import-attributes-null-babel-7/input.js
@@ -0,0 +1 @@
+import("module");
diff --git a/packages/babel-parser/test/fixtures/estree/dynamic-import/import-attributes-null-babel-7/options.json b/packages/babel-parser/test/fixtures/estree/dynamic-import/import-attributes-null-babel-7/options.json
@@ -0,0 +1,6 @@
+{
+  "plugins": [
+    "estree"
+  ],
+  "BABEL_8_BREAKING": false
+}
diff --git a/packages/babel-parser/test/fixtures/estree/dynamic-import/import-attributes-null-babel-7/output.json b/packages/babel-parser/test/fixtures/estree/dynamic-import/import-attributes-null-babel-7/output.json
@@ -0,0 +1,28 @@
+{
+  "type": "File",
+  "start":0,"end":17,"loc":{"start":{"line":1,"column":0},"end":{"line":1,"column":17}},
+  "program": {
+    "type": "Program",
+    "start":0,"end":17,"loc":{"start":{"line":1,"column":0},"end":{"line":1,"column":17}},
+    "sourceType": "script",
+    "interpreter": null,
+    "body": [
+      {
+        "type": "ExpressionStatement",
+        "start":0,"end":17,"loc":{"start":{"line":1,"column":0},"end":{"line":1,"column":17}},
+        "expression": {
+          "type": "ImportExpression",
+          "start":0,"end":16,"loc":{"start":{"line":1,"column":0},"end":{"line":1,"column":16}},
+          "source": {
+            "type": "Literal",
+            "start":7,"end":15,"loc":{"start":{"line":1,"column":7},"end":{"line":1,"column":15}},
+            "value": "module",
+            "raw": "\"module\""
+          },
+          "options": null,
+          "attributes": null
+        }
+      }
+    ]
+  }
+}
diff --git a/packages/babel-parser/test/fixtures/estree/dynamic-import/import-attributes-null/options.json b/packages/babel-parser/test/fixtures/estree/dynamic-import/import-attributes-null/options.json
@@ -1,3 +1,6 @@
 {
-  "plugins": ["estree"]
+  "plugins": [
+    "estree"
+  ],
+  "BABEL_8_BREAKING": true
 }
diff --git a/packages/babel-parser/test/fixtures/estree/dynamic-import/import-attributes-null/output.json b/packages/babel-parser/test/fixtures/estree/dynamic-import/import-attributes-null/output.json
@@ -19,8 +19,7 @@
             "value": "module",
             "raw": "\"module\""
           },
-          "options": null,
-          "attributes": null
+          "options": null
         }
       }
     ]
diff --git a/packages/babel-parser/test/fixtures/estree/dynamic-import/import-attributes/options.json b/packages/babel-parser/test/fixtures/estree/dynamic-import/import-attributes/options.json
@@ -1,3 +1,6 @@
 {
-  "plugins": ["estree"]
+  "plugins": [
+    "estree"
+  ],
+  "BABEL_8_BREAKING": true
 }
diff --git a/packages/babel-parser/test/fixtures/estree/dynamic-import/import-attributes/output.json b/packages/babel-parser/test/fixtures/estree/dynamic-import/import-attributes/output.json
diff --git a/packages/babel-plugin-transform-classes/src/inline-callSuper-helpers.ts b/packages/babel-plugin-transform-classes/src/inline-callSuper-helpers.ts
diff --git a/packages/babel-plugin-transform-runtime/src/index.ts b/packages/babel-plugin-transform-runtime/src/index.ts
diff --git a/packages/babel-preset-env/src/index.ts b/packages/babel-preset-env/src/index.ts
