[setPublicClassFields] Use define for static name/length (#14351)

nicolo-ribaudo · web-flow · commit 8855e4c27e8b · 2022-03-22T10:13:28.000-04:00
* [setPublicClassFields] Use define for static `name`/`length`

* Cache property access
diff --git a/packages/babel-helper-create-class-features-plugin/src/fields.ts b/packages/babel-helper-create-class-features-plugin/src/fields.ts
@@ -936,6 +936,16 @@ export type PropNode =
   | t.StaticBlock;
 export type PropPath = NodePath<PropNode>;
 
+function isNameOrLength({ key, computed }: t.ClassProperty) {
+  if (key.type === "Identifier") {
+    return !computed && (key.name === "name" || key.name === "length");
+  }
+  if (key.type === "StringLiteral") {
+    return key.value === "name" || key.value === "length";
+  }
+  return false;
+}
+
 export function buildFieldsInitNodes(
   ref: t.Identifier,
   superRef: t.Expression | undefined,
@@ -1019,10 +1029,19 @@ export function buildFieldsInitNodes(
         );
         break;
       case isStatic && isPublic && isField && setPublicClassFields:
-        needsClassRef = true;
+        // Functions always have non-writable .name and .length properties,
+        // so we must always use [[Define]] for them.
+        // It might still be possible to a computed static fields whose resulting
+        // key is "name" or "length", but the assumption is telling us that it's
+        // not going to happen.
         // @ts-expect-error checked in switch
-        staticNodes.push(buildPublicFieldInitLoose(t.cloneNode(ref), prop));
-        break;
+        if (!isNameOrLength(prop.node)) {
+          needsClassRef = true;
+          // @ts-expect-error checked in switch
+          staticNodes.push(buildPublicFieldInitLoose(t.cloneNode(ref), prop));
+          break;
+        }
+      // falls through
       case isStatic && isPublic && isField && !setPublicClassFields:
         needsClassRef = true;
         staticNodes.push(
diff --git a/packages/babel-plugin-proposal-class-properties/test/fixtures/assumption-setPublicClassFields/length-name-use-define/input.js b/packages/babel-plugin-proposal-class-properties/test/fixtures/assumption-setPublicClassFields/length-name-use-define/input.js
@@ -0,0 +1,12 @@
+class A {
+    static name = 1;
+    static length = 2;
+    static foo = 3;
+    static [bar] = 4;
+    static ["name"] = 5;
+    static [name] = 6;
+    static "name" = 7;
+
+    name = 8;
+    length = 9;
+}
diff --git a/packages/babel-plugin-proposal-class-properties/test/fixtures/assumption-setPublicClassFields/length-name-use-define/output.js b/packages/babel-plugin-proposal-class-properties/test/fixtures/assumption-setPublicClassFields/length-name-use-define/output.js
@@ -0,0 +1,20 @@
+let _bar, _name;
+
+_bar = bar;
+_name = name;
+
+class A {
+  constructor() {
+    this.name = 8;
+    this.length = 9;
+  }
+
+}
+
+babelHelpers.defineProperty(A, "name", 1);
+babelHelpers.defineProperty(A, "length", 2);
+A.foo = 3;
+A[_bar] = 4;
+babelHelpers.defineProperty(A, "name", 5);
+A[_name] = 6;
+babelHelpers.defineProperty(A, "name", 7);
