fix: do not initialize abstract property / accessor (#15344)

liuxingbaoyu · web-flow · commit 7f13bf9c248e · 2023-01-12T11:48:13.000-05:00
diff --git a/packages/babel-plugin-transform-typescript/src/index.ts b/packages/babel-plugin-transform-typescript/src/index.ts
@@ -160,6 +160,8 @@ export default declare((api, opts: Options) => {
             path.remove();
           }
         }
+      } else if (node.abstract) {
+        path.remove();
       } else if (!process.env.BABEL_8_BREAKING) {
         if (
           !allowDeclareFields &&
diff --git a/packages/babel-plugin-transform-typescript/test/fixtures/class/abstract-allowDeclareFields-false/input.ts b/packages/babel-plugin-transform-typescript/test/fixtures/class/abstract-allowDeclareFields-false/input.ts
@@ -0,0 +1,3 @@
+abstract class A {
+    abstract prop: string;
+}
diff --git a/packages/babel-plugin-transform-typescript/test/fixtures/class/abstract-allowDeclareFields-false/options.json b/packages/babel-plugin-transform-typescript/test/fixtures/class/abstract-allowDeclareFields-false/options.json
@@ -0,0 +1,3 @@
+{
+  "plugins": [["transform-typescript", { "allowDeclareFields": false }]]
+}
diff --git a/packages/babel-plugin-transform-typescript/test/fixtures/class/abstract-allowDeclareFields-false/output.js b/packages/babel-plugin-transform-typescript/test/fixtures/class/abstract-allowDeclareFields-false/output.js
@@ -0,0 +1 @@
+class A {}
diff --git a/packages/babel-plugin-transform-typescript/test/fixtures/class/abstract-allowDeclareFields-true/input.ts b/packages/babel-plugin-transform-typescript/test/fixtures/class/abstract-allowDeclareFields-true/input.ts
@@ -0,0 +1,3 @@
+abstract class A {
+    abstract prop: string;
+}
diff --git a/packages/babel-plugin-transform-typescript/test/fixtures/class/abstract-allowDeclareFields-true/options.json b/packages/babel-plugin-transform-typescript/test/fixtures/class/abstract-allowDeclareFields-true/options.json
@@ -0,0 +1,3 @@
+{
+  "plugins": [["transform-typescript", { "allowDeclareFields": true }]]
+}
diff --git a/packages/babel-plugin-transform-typescript/test/fixtures/class/abstract-allowDeclareFields-true/output.js b/packages/babel-plugin-transform-typescript/test/fixtures/class/abstract-allowDeclareFields-true/output.js
@@ -0,0 +1 @@
+class A {}
diff --git a/packages/babel-plugin-transform-typescript/test/fixtures/class/accessor-allowDeclareFields-false/output.js b/packages/babel-plugin-transform-typescript/test/fixtures/class/accessor-allowDeclareFields-false/output.js
@@ -4,11 +4,8 @@ class Foo {
   accessor #prop3 = 1;
   accessor [prop4] = 1;
   accessor prop5 = 1;
-  accessor prop6;
   accessor #p;
   accessor a;
   accessor aa;
-  accessor #s;
-  accessor f = 1;
   accessor g;
 }
diff --git a/packages/babel-plugin-transform-typescript/test/fixtures/class/accessor-allowDeclareFields-true-babel-7/output.js b/packages/babel-plugin-transform-typescript/test/fixtures/class/accessor-allowDeclareFields-true-babel-7/output.js
@@ -4,5 +4,4 @@ class Foo {
   accessor #prop3 = 1;
   accessor [prop4] = 1;
   accessor prop5 = 1;
-  accessor f = 1;
 }
diff --git a/packages/babel-plugin-transform-typescript/test/fixtures/class/accessor-allowDeclareFields-true/output.js b/packages/babel-plugin-transform-typescript/test/fixtures/class/accessor-allowDeclareFields-true/output.js
@@ -4,11 +4,8 @@ class Foo {
   accessor #prop3 = 1;
   accessor [prop4] = 1;
   accessor prop5 = 1;
-  accessor prop6;
   accessor #p;
   accessor a;
   accessor aa;
-  accessor #s;
-  accessor f = 1;
   accessor g;
 }

Original file line number	Diff line number	Diff line change
`@@ -160,6 +160,8 @@ export default declare((api, opts: Options) => {`
`160`	`160`	`path.remove();`
`161`	`161`	`}`
`162`	`162`	`}`
	`163`	`+ } else if (node.abstract) {`
	`164`	`+ path.remove();`
`163`	`165`	`} else if (!process.env.BABEL_8_BREAKING) {`
`164`	`166`	`if (`
`165`	`167`	`!allowDeclareFields &&`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+abstract class A {`
	`2`	`+ abstract prop: string;`
	`3`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+{`
	`2`	`+ "plugins": [["transform-typescript", { "allowDeclareFields": false }]]`
	`3`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -4,5 +4,4 @@ class Foo {`
`4`	`4`	`accessor #prop3 = 1;`
`5`	`5`	`accessor [prop4] = 1;`
`6`	`6`	`accessor prop5 = 1;`
`7`		`- accessor f = 1;`
`8`	`7`	`}`