fix: TS plugin shouldn't remove #privateField! (#14890)

liuxingbaoyu · web-flow · commit 7ddad4742d37 · 2022-08-30T08:37:34.000-04:00
diff --git a/packages/babel-plugin-transform-typescript/src/index.ts b/packages/babel-plugin-transform-typescript/src/index.ts
@@ -124,7 +124,11 @@ export default declare((api, opts: Options) => {
         if (!process.env.BABEL_8_BREAKING) {
           // keep the definitely assigned fields only when `allowDeclareFields` (equivalent of
           // Typescript's `useDefineForClassFields`) is true
-          if (!allowDeclareFields && !node.decorators) {
+          if (
+            !allowDeclareFields &&
+            !node.decorators &&
+            !t.isClassPrivateProperty(node)
+          ) {
             path.remove();
           }
         }
diff --git a/packages/babel-plugin-transform-typescript/test/fixtures/class/uninitialized-definite-babel-7/input.ts b/packages/babel-plugin-transform-typescript/test/fixtures/class/uninitialized-definite-babel-7/input.ts
@@ -1,3 +1,5 @@
 class A {
   x!;
+
+  #y!;
 }
diff --git a/packages/babel-plugin-transform-typescript/test/fixtures/class/uninitialized-definite-babel-7/output.js b/packages/babel-plugin-transform-typescript/test/fixtures/class/uninitialized-definite-babel-7/output.js
@@ -1,3 +1,4 @@
 class A {
   x;
+  #y;
 }
diff --git a/packages/babel-plugin-transform-typescript/test/fixtures/class/uninitialized-definite-with-declare-disabled-babel-7/input.ts b/packages/babel-plugin-transform-typescript/test/fixtures/class/uninitialized-definite-with-declare-disabled-babel-7/input.ts
@@ -1,3 +1,5 @@
 class A {
   x!;
+
+  #y!;
 }
diff --git a/packages/babel-plugin-transform-typescript/test/fixtures/class/uninitialized-definite-with-declare-disabled-babel-7/output.js b/packages/babel-plugin-transform-typescript/test/fixtures/class/uninitialized-definite-with-declare-disabled-babel-7/output.js
@@ -1 +1,3 @@
-class A {}
+class A {
+  #y;
+}

Original file line number	Diff line number	Diff line change
`@@ -124,7 +124,11 @@ export default declare((api, opts: Options) => {`
`124`	`124`	`if (!process.env.BABEL_8_BREAKING) {`
`125`	`125`	// keep the definitely assigned fields only when `allowDeclareFields` (equivalent of
`126`	`126`	// Typescript's `useDefineForClassFields`) is true
`127`		`- if (!allowDeclareFields && !node.decorators) {`
	`127`	`+ if (`
	`128`	`+ !allowDeclareFields &&`
	`129`	`+ !node.decorators &&`
	`130`	`+ !t.isClassPrivateProperty(node)`
	`131`	`+ ) {`
`128`	`132`	`path.remove();`
`129`	`133`	`}`
`130`	`134`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
`1`	`1`	`class A {`
`2`	`2`	`x!;`
	`3`	`+`
	`4`	`+ #y!;`
`3`	`5`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
`1`	`1`	`class A {`
`2`	`2`	`x;`
	`3`	`+ #y;`
`3`	`4`	`}`
-Original file line number
+Diff line change
@@ @@ -1 +1,3 @@ @@
 -class A {}
 +class A {
 +  #y;
 +}