Always print directives with double quotes when minified (#14094)

overlookmotel · web-flow · commit 3942d7274548 · 2022-01-06T16:28:28.000+01:00
diff --git a/packages/babel-generator/src/generators/base.ts b/packages/babel-generator/src/generators/base.ts
@@ -58,7 +58,7 @@ const unescapedDoubleQuoteRE = /(?:^|[^\\])(?:\\\\)*"/;
 
 export function DirectiveLiteral(this: Printer, node: t.DirectiveLiteral) {
   const raw = this.getPossibleRaw(node);
-  if (raw != null) {
+  if (!this.format.minified && raw != null) {
     this.token(raw);
     return;
   }
diff --git a/packages/babel-generator/test/index.js b/packages/babel-generator/test/index.js
@@ -548,6 +548,20 @@ describe("programmatic generation", function () {
         generate(directive);
       }).toThrow();
     });
+
+    it("preserves single quotes if not minified", function () {
+      const directive = parse("'use strict';").program.directives[0];
+      const output = generate(directive).code;
+
+      expect(output).toBe("'use strict';");
+    });
+
+    it("converts single quotes to double quotes if minified", function () {
+      const directive = parse("'use strict';").program.directives[0];
+      const output = generate(directive, { minified: true }).code;
+
+      expect(output).toBe('"use strict";');
+    });
   });
 
   describe("typescript generate parentheses if necessary", function () {

Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,7 @@ const unescapedDoubleQuoteRE = /(?:^\|[^\\])(?:\\\\)*"/;`
`58`	`58`
`59`	`59`	`export function DirectiveLiteral(this: Printer, node: t.DirectiveLiteral) {`
`60`	`60`	`const raw = this.getPossibleRaw(node);`
`61`		`- if (raw != null) {`
	`61`	`+ if (!this.format.minified && raw != null) {`
`62`	`62`	`this.token(raw);`
`63`	`63`	`return;`
`64`	`64`	`}`