Allow $schema property in json config files (#14067)

The-x-Theorist · web-flow · commit 2c68d03bf29e · 2021-12-28T22:13:14.000-05:00
* Fix: Error on  property in json config files

* options[] delete moved down
diff --git a/packages/babel-core/src/config/files/configuration.ts b/packages/babel-core/src/config/files/configuration.ts
@@ -272,6 +272,8 @@ const readConfigJSON5 = makeStaticFileCache((filepath, content): ConfigFile => {
     throw new Error(`${filepath}: Expected config object but found array`);
   }
 
+  delete options["$schema"];
+
   return {
     filepath,
     dirname: path.dirname(filepath),
diff --git a/packages/babel-core/test/config-chain.js b/packages/babel-core/test/config-chain.js
@@ -1343,5 +1343,19 @@ describe("buildConfigChain", function () {
         });
       }).toThrow(/Preset \/\* your preset \*\/ requires a filename/);
     });
+
+    it("should not throw error on $schema property in json config files", () => {
+      const filename = fixture(
+        "config-files",
+        "babel-config-json-$schema-property",
+        "babel.config.json",
+      );
+      expect(() => {
+        babel.loadPartialConfig({
+          filename,
+          cwd: path.dirname(filename),
+        });
+      }).not.toThrow();
+    });
   });
 });
diff --git a/packages/babel-core/test/fixtures/config/config-files/babel-config-json-$schema-property/babel.config.json b/packages/babel-core/test/fixtures/config/config-files/babel-config-json-$schema-property/babel.config.json
@@ -0,0 +1,3 @@
+{
+  "$schema": "https://json.schemastore.org/babelrc"
+}

Original file line number	Diff line number	Diff line change
`@@ -272,6 +272,8 @@ const readConfigJSON5 = makeStaticFileCache((filepath, content): ConfigFile => {`
`272`	`272`	throw new Error(`${filepath}: Expected config object but found array`);
`273`	`273`	`}`
`274`	`274`
	`275`	`+ delete options["$schema"];`
	`276`	`+`
`275`	`277`	`return {`
`276`	`278`	`filepath,`
`277`	`279`	`dirname: path.dirname(filepath),`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+{`
	`2`	`+ "$schema": "https://json.schemastore.org/babelrc"`
	`3`	`+}`