src: remove unused warning in node_contextify

targos · addaleax · commit abf81aec7d19 · 2017-10-26T21:10:36.000+02:00
PR-URL: nodejs/node#16408 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
diff --git a/src/node_contextify.cc b/src/node_contextify.cc
@@ -440,7 +440,8 @@ class ContextifyContext {
             desc_for_sandbox->set_configurable(desc.configurable());
           }
           // Set the property on the sandbox.
-          sandbox->DefineProperty(context, property, *desc_for_sandbox);
+          sandbox->DefineProperty(context, property, *desc_for_sandbox)
+              .FromJust();
         };
 
     if (desc.has_get() || desc.has_set()) {

Original file line number	Diff line number	Diff line change
`@@ -440,7 +440,8 @@ class ContextifyContext {`
`440`	`440`	`desc_for_sandbox->set_configurable(desc.configurable());`
`441`	`441`	`}`
`442`	`442`	`// Set the property on the sandbox.`
`443`		`- sandbox->DefineProperty(context, property, *desc_for_sandbox);`
	`443`	`+ sandbox->DefineProperty(context, property, *desc_for_sandbox)`
	`444`	`+ .FromJust();`
`444`	`445`	`};`
`445`	`446`
`446`	`447`	`if (desc.has_get() \|\| desc.has_set()) {`