buffer: buffer.transcode to use internal/errors

starkwang · addaleax · commit 1935a92cacf0 · 2017-12-07T17:33:54.000+01:00
`buffer.transcode` is still using raw TypeError. This change is to convert it to use internal/errors. Ref: nodejs/node#11273 PR-URL: nodejs/node#16352 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
diff --git a/lib/buffer.js b/lib/buffer.js
@@ -1562,7 +1562,8 @@ if (process.binding('config').hasIntl) {
   // Buffer instance.
   transcode = function transcode(source, fromEncoding, toEncoding) {
     if (!isUint8Array(source))
-      throw new TypeError('"source" argument must be a Buffer or Uint8Array');
+      throw new errors.TypeError('ERR_INVALID_ARG_TYPE', 'source',
+                                 ['Buffer', 'Uint8Array'], source);
     if (source.length === 0) return Buffer.alloc(0);
 
     fromEncoding = normalizeEncoding(fromEncoding) || fromEncoding;
diff --git a/test/parallel/test-icu-transcode.js b/test/parallel/test-icu-transcode.js
@@ -41,9 +41,14 @@ for (const test in tests) {
                      utf8_to_ucs2.toString('ucs2'));
 }
 
-assert.throws(
+common.expectsError(
   () => buffer.transcode(null, 'utf8', 'ascii'),
-  /^TypeError: "source" argument must be a Buffer or Uint8Array$/
+  {
+    type: TypeError,
+    code: 'ERR_INVALID_ARG_TYPE',
+    message: 'The "source" argument must be one of type Buffer ' +
+             'or Uint8Array. Received type null'
+  }
 );
 
 assert.throws(
