Skip to content

Fixing custom config options#2207

Merged
felipewmartins merged 1 commit intoaxios:masterfrom
rafaelrenanpacheco:custom-config
Sep 7, 2019
Merged

Fixing custom config options#2207
felipewmartins merged 1 commit intoaxios:masterfrom
rafaelrenanpacheco:custom-config

Conversation

@rafaelrenanpacheco
Copy link
Copy Markdown
Contributor

This PR is a conflict fix of #2006 with some code style fix as well. The main work was done by @oleduc.

@rafaelrenanpacheco
Copy link
Copy Markdown
Contributor Author

@jasonsaayman, here it is 👍

@vvo
Copy link
Copy Markdown

vvo commented Jun 27, 2019

I hate to do so, but seeing you did the last release @emilyemorehouse could you give us your advice on this PR? The caching module axio README provides is not working as of axios 0.19. Thanks!

@mohamedgomran
Copy link
Copy Markdown

mohamedgomran commented Jun 28, 2019

When this can be merged? a lot of plugins have stopped working and waiting for this.

@akirilyuk
Copy link
Copy Markdown

When this will be merged? We would need to implement own solutions otherwise instead using plugins...

@codeclown
Copy link
Copy Markdown
Contributor

@emilyemorehouse @nickuraltsev FWIW, as author of #1395 I'd approve this PR and merge it.

As messy as it is to allow including any properties carried around in the axios config, it was the past behaviour and should definitely be restored. I was not aware of such functionality being relied upon by third-party plugins when making the original PR.

@jondavidjohn
Copy link
Copy Markdown

Even if the breaking change stands, is there a strategy for plugins having custom config options to migrate to?

@eaviles
Copy link
Copy Markdown

eaviles commented Jul 23, 2019

Looking forward to see this resolved. It would fix: softonic/axios-retry#82

@sustained
Copy link
Copy Markdown

Is this going to be merged?

@ruscon
Copy link
Copy Markdown

ruscon commented Aug 22, 2019

@rafaelrenanpacheco, can you approve this pull request ?

@ghost
Copy link
Copy Markdown

ghost commented Aug 27, 2019

Is there any ETA on this?

@simllll
Copy link
Copy Markdown

simllll commented Sep 6, 2019

Anything we can do to get this into the master?

@jphilipstevens
Copy link
Copy Markdown

Hey,

I am a new maintainer for this project. I updated @emilyemorehouse about it. I see one conflict. I am happy to merge unless someone has a clear objection.

There is a conflict right now that needs to be addressed

@rafaelrenanpacheco
Copy link
Copy Markdown
Contributor Author

@jphilipstevens all done!

@felipewmartins
Copy link
Copy Markdown
Contributor

Can I merge this pull request?

@felipewmartins
Copy link
Copy Markdown
Contributor

@jphilipstevens

@ruscon
Copy link
Copy Markdown

ruscon commented Sep 6, 2019

@rafaelrenanpacheco @felipewmartins as I see, the project does not use the merge strategy.

@rafaelrenanpacheco
Copy link
Copy Markdown
Contributor Author

@rafaelrenanpacheco @felipewmartins as I see, the project does not use the merge strategy.

what

@ruscon
Copy link
Copy Markdown

ruscon commented Sep 6, 2019

@rafaelrenanpacheco rebase if you can :)

@axios axios locked and limited conversation to collaborators May 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Custom properties for config