v2 - Params builders do not supply default TransformationManager

Consider for instance SSMProvider - if a TransformationManager is not supplied, a default will not be provided. You can contrast this with CacheManager.

powertools-lambda-java/powertools-parameters/powertools-parameters-ssm/src/main/java/software/amazon/lambda/powertools/parameters/ssm/SSMProviderBuilder.java

Lines 51 to 63 in fb14bcf

    
           public SSMProvider build() { 
        
               if (cacheManager == null) { 
        
                   cacheManager = new CacheManager(); 
        
               } 
        
               SSMProvider provider; 
        
               if (client == null) { 
        
                   client = createClient(); 
        
               } 
        
               provider = new SSMProvider(cacheManager, transformationManager, client); 
        
               return provider; 
        
           }

This causes issues in our parameters example, which will throw due to a lack of TransformationManager:

powertools-lambda-java/examples/powertools-examples-parameters/src/main/java/org/demo/parameters/ParametersFunction.java

Line 59 in fb14bcf

    
           MyObject jsonObj = ssmProvider.withTransformation(json).get("/powertools-java/sample/keyjson", MyObject.class);

powertools-lambda-java/examples/powertools-examples-parameters/src/main/java/org/demo/parameters/ParametersFunction.java

Lines 63 to 64 in fb14bcf

    
           Map<String, String> secretJson = 
        
                   secretsProvider.withTransformation(json).get("/powertools-java/userpwd", Map.class);

What were you trying to accomplish?

Expected Behavior

V2 parameters example should work.

Possible Solution

A default TransformationManager should be provided.

@ritigupt

@ritigupt working on this as part of #1546

Navigation Menu

Repository navigation

v2 - Params builders do not supply default TransformationManager #1544

Expected Behavior

Possible Solution

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	public SSMProvider build() {
	if (cacheManager == null) {
	cacheManager = new CacheManager();
	}
	SSMProvider provider;
	if (client == null) {
	client = createClient();
	}

	provider = new SSMProvider(cacheManager, transformationManager, client);

	return provider;
	}

	Map<String, String> secretJson =
	secretsProvider.withTransformation(json).get("/powertools-java/userpwd", Map.class);

v2 - Params builders do not supply default TransformationManager #1544

Description

Expected Behavior

Possible Solution

Activity

scottgerring commented on Jan 3, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions