Skip to content

It looks like the upgrade to 2.1.6 has broken dependency installation in cfn submit --dry-run #235

Closed

Description

@andyloughran

The pip installation in cfn submit appears to log pip usage instructions to stdout instead of actually installing the depenencies.

If we downgrade to 2.1.5 then the dependencies are included in the build dir.

If we run 2.1.6, then the build directory does not contain any of the pip dependencies that we'd expect.

This is consistent if I downgrade and then re-upgrade, but I don't have a public project i can share to demonstrate the behaviour.

Example .rpdk-config:

    "artifact_type": "HOOK",
    "typeName": "XXX::XXX::XXX",
    "language": "python37",
    "runtime": "python3.7",
    "entrypoint": "xxx.handlers.hook",
    "testEntrypoint": "xxx.handlers.hook",
    "settings": {
        "version": false,
        "subparser_name": null,
        "verbose": 0,
        "force": false,
        "type_name": null,
        "artifact_type": null,
        "endpoint_url": null,
        "region": null,
        "target_schemas": [],
        "use_docker": false,
        "protocolVersion": "2.0.0"
    }
}

Activity

  1. mmaeng commented on Dec 19, 2022

    @mmaeng
    Contributor

    Thanks for the report! Taking a look.

  2. added
    bugSomething isn't working
    and removed on Dec 19, 2022
  3. mmaeng commented on Dec 19, 2022

    @mmaeng
    Contributor

    @andyloughran Got a fix in place for this going forward and it should get included in the next release. In the meantime alternatives would be

    1. Downgrade to 2.1.5 until next release
    2. run off master branch
    3. use docker containers to build your hook, if you want to try building the resource/hook in a container you can edit your .rpdk-config file in the root of your resource and change use_docker from false to true
  4. andyloughran commented on Dec 19, 2022

    @andyloughran
    Author
  5. mmaeng commented on Dec 19, 2022

    @mmaeng
    Contributor

    No problem at all, we are working on making improvements all around and reports like this are extremely helpful!

    We are also available on AWS CloudFormation Discord!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingp0High Priority

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions