Skip to content

Sensitive data should not be logged #221

Closed

Description

@divyansh-gupta

I am developing a resource and have placed a property in the resource schema writeOnlyProperties category. This marks the property as sensitive. However, the property value is still logged when the Handler is run.

This is where the logging is happening: https://github.com/aws-cloudformation/cloudformation-cli-java-plugin/blob/master/src/main/java/software/amazon/cloudformation/proxy/CloudFormationCallbackAdapter.java#L81-L82

Sensitive data like this should not be logged. Would appreciate a fix, let me know if I can provide more information. Thanks!

Activity

  1. johnttompkins commented on Jan 8, 2020

    @johnttompkins
    Contributor

    Change is merged in. Going to leave this open until we release a new version to maven which includes changes

  2. johnttompkins commented on Jan 15, 2020

    @johnttompkins
    Contributor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions