Pin major Pester version to 4 to prevent breaking changes caused by upcoming release of v5 (PowerShell#12262)

bergmeister · web-flow · commit a29cffd49d31 · 2020-04-14T11:21:19.000+05:00
diff --git a/.vsts-ci/misc-analysis.yml b/.vsts-ci/misc-analysis.yml
@@ -34,7 +34,7 @@ jobs:
     condition: succeededOrFailed()
 
   - powershell: |
-      Install-module pester -Scope CurrentUser -Force
+      Install-module Pester -Scope CurrentUser -Force -MaximumVersion 4.99
     displayName: Install Pester
     condition: succeededOrFailed()
 
diff --git a/.vsts-ci/templates/nanoserver.yml b/.vsts-ci/templates/nanoserver.yml
@@ -34,7 +34,7 @@ jobs:
     continueOnError: true
 
   - pwsh: |
-      Install-module pester -Scope CurrentUser -Force
+      Install-module Pester -Scope CurrentUser -Force -MaximumVersion 4.99
     displayName: 'Install Pester'
     continueOnError: true
 
diff --git a/build.psm1 b/build.psm1
@@ -689,7 +689,7 @@ function Restore-PSPester
         [ValidateNotNullOrEmpty()]
         [string] $Destination = ([IO.Path]::Combine((Split-Path (Get-PSOptions -DefaultToNew).Output), "Modules"))
     )
-    Save-Module -Name Pester -Path $Destination -Repository PSGallery -RequiredVersion "4.8.0"
+    Save-Module -Name Pester -Path $Destination -Repository PSGallery -MaximumVersion 4.99
 }
 
 function Compress-TestContent {
diff --git a/tools/ci.psm1 b/tools/ci.psm1
@@ -492,8 +492,9 @@ function Invoke-CIFinish
         $env:PSMsiX64Path = $artifacts | Where-Object { $_.EndsWith(".msi")}
 
         # Install the latest Pester and import it
-        Install-Module Pester -Force -SkipPublisherCheck
-        Import-Module Pester -Force
+        $maximumPesterVersion = '4.99'
+        Install-Module Pester -Force -SkipPublisherCheck -MaximumVersion $maximumPesterVersion
+        Import-Module Pester -Force -MaximumVersion $maximumPesterVersion
 
         # start the packaging tests and get the results
         $packagingTestResult = Invoke-Pester -Script (Join-Path $repoRoot '.\test\packaging\windows\') -PassThru

Original file line number	Diff line number	Diff line change
`@@ -689,7 +689,7 @@ function Restore-PSPester`
`689`	`689`	`[ValidateNotNullOrEmpty()]`
`690`	`690`	`[string] $Destination = ([IO.Path]::Combine((Split-Path (Get-PSOptions -DefaultToNew).Output), "Modules"))`
`691`	`691`	`)`
`692`		`- Save-Module -Name Pester -Path $Destination -Repository PSGallery -RequiredVersion "4.8.0"`
	`692`	`+ Save-Module -Name Pester -Path $Destination -Repository PSGallery -MaximumVersion 4.99`
`693`	`693`	`}`
`694`	`694`
`695`	`695`	`function Compress-TestContent {`