182 Refactoring

id774 · id774 · commit 6ceea6bfbcf9 · 2012-06-17T23:31:56.000+09:00
diff --git a/lib/automatic/pipeline.rb b/lib/automatic/pipeline.rb
@@ -20,7 +20,8 @@ def self.load_plugin(module_name)
         subdir = File.basename dir
         if /#{subdir}_(.*)$/ =~ module_name.underscore
           path = dir + "/#{$1}.rb"
-          return Automatic::Plugin.autoload module_name.to_sym, path.to_s if File.exists? path
+          return Automatic::Plugin.autoload module_name.to_sym,
+            path.to_s if File.exists? path
         end
       }
       raise NoPluginError, "unknown plugin named #{module_name}"
diff --git a/plugins/filter/image_source.rb b/plugins/filter/image_source.rb
@@ -25,7 +25,7 @@ def parse_array(string)
     end
 
     def run
-      return_feeds = []
+      @return_feeds = []
       @pipeline.each {|feeds|
         img_url = ""
         unless feeds.nil?
@@ -38,9 +38,9 @@ def run
             end
           }
         end
-        return_feeds << feeds
+        @return_feeds << feeds
       }
-      return_feeds
+      @return_feeds
     end
   end
 end
diff --git a/plugins/filter/reverse.rb b/plugins/filter/reverse.rb
@@ -16,17 +16,17 @@ def initialize(config, pipeline=[])
     end
 
     def run
-      return_feeds = []
+      @return_feeds = []
       @pipeline.each { |feeds|
         return_feed_items = []
         unless feeds.nil?
           feeds.items.sort!{|a,b|
             a.date <=> b.date
           }
-          return_feeds << feeds
+          @return_feeds << feeds
         end
       }
-      return_feeds
+      @return_feeds
     end
   end
 end
diff --git a/plugins/filter/tumblr_resize.rb b/plugins/filter/tumblr_resize.rb
@@ -23,17 +23,17 @@ def resize(string)
     end
 
     def run
-      return_feeds = []
+      @return_feeds = []
       @pipeline.each {|feeds|
         img_url = ""
         unless feeds.nil?
           feeds.items.each {|feed|
             feed.link = resize(feed.link) unless feed.link.nil?
           }
         end
-        return_feeds << feeds
+        @return_feeds << feeds
       }
-      return_feeds
+      @return_feeds
     end
   end
 end
diff --git a/plugins/store/database.rb b/plugins/store/database.rb
@@ -1,8 +1,9 @@
 # -*- coding: utf-8 -*-
 # Name::      Automatic::Plugin::Store::Database
 # Author::    kzgs
+#             774 <http://id774.net>
 # Created::   Feb 27, 2012
-# Updated::   Jun 14, 2012
+# Updated::   Jun 17, 2012
 # Copyright:: kzgs Copyright (c) 2012
 # License::   Licensed under the GNU GENERAL PUBLIC LICENSE, Version 3.0.
 
@@ -30,7 +31,7 @@ def for_each_new_link
     def for_each_new_feed
       prepare_database
       existing_records = model_class.find(:all)
-      return_feeds = []
+      @return_feeds = []
       @pipeline.each { |feeds|
         unless feeds.nil?
           new_feed = false
@@ -40,10 +41,10 @@ def for_each_new_feed
               new_feed = true
             end
           }
-          return_feeds << feeds if new_feed
+          @return_feeds << feeds if new_feed
         end
       }
-      return_feeds
+      @return_feeds
     end
 
     private
